Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190220233658.986-1-eric@anholt.net> <CAApk1dVubN7ME6GNuedGmF4V1qnH_JYnSEvFffAzwsMFaZNmgg@mail.gmail.com>
 <87o96l71im.fsf@anholt.net>
In-Reply-To: <87o96l71im.fsf@anholt.net>
From:   Dave Emett <david.emett@broadcom.com>
Date:   Fri, 8 Mar 2019 18:10:56 +0000
Message-ID: <CAApk1dW8Du3C-7dz5UPQuRTk=NvQHW33q+Sia_nmm2n3JaN_mQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2.
To:     Eric Anholt <eric@anholt.net>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Thomas Spurden <thomas.spurden@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 8 Mar 2019 at 16:51, Eric Anholt <eric@anholt.net> wrote:
>
> Dave Emett <david.emett@broadcom.com> writes:
>
> > Sorry, a few things I thought of after sending the Reviewed-by email...
> >
> >> +       v3d->reset = devm_reset_control_get_exclusive(dev, NULL);
> >> +       if (IS_ERR(v3d->reset)) {
> >> +               ret = PTR_ERR(v3d->reset);
> >> +
> >> +               if (ret == -EPROBE_DEFER)
> >> +                       goto dev_free;
> > Might be preferable to make this explicitly check against the
> > not-found error code (whatever that is)? As in if (not found)
> > <fallback to bridge> else <return error code>. Similarly...
>
> You won't have both a bridge and an external reset controller in the DT,
> so I'm not clear on what functional change you're looking for.  You're
> just concerned about what the return code from this function is?
> -EPROBE_DEFER is the only one that matters from a probe, really.

I don't think it matters here. I just figured it should probably be
done the same way as the IRQ.

> >> +       if (platform_get_irq(v3d->pdev, 1) < 0) {
> > This should probably explicitly check for not-found rather than any
> > error. As-is, we might silently go down the single-interrupt-line path
> > on a platform with 2 interrupt lines if platform_get_irq(v3d->pdev, 1)
> > hits some other error.
>
> If I do the -EPROBE_DEFER check here, will that be good enough for you?

If that's the only other error we can get then sure. It wasn't clear
to me what errors might be returned from platform_get_irq.