Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/4] Add header file,Kconfig and Makefile
To:     Morris Ku <saumah@gmail.com>, gregkh@linuxfoundation.org
Cc:     morris_ku@sunix.com, linux-kernel@vger.kernel.org, arnd@arndb.de
References: <20190308123547.20578-1-saumah@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <c23c156e-0493-96e2-f4eb-0171e8c8fc58@infradead.org>
Date:   Fri, 8 Mar 2019 19:15:32 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190308123547.20578-1-saumah@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/8/19 4:35 AM, Morris Ku wrote:
> This patch add header file, Kconfig and Makefile. 
> 
> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---

> diff --git a/char/snx/Kconfig b/char/snx/Kconfig
> new file mode 100644
> index 00000000..86f38352
> --- /dev/null
> +++ b/char/snx/Kconfig
> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Character device configuration
> +#
> +
> +config SNX
> +	tristate "SUNIX Multi-IO Board Drvier"

	                               Driver

> +	Driver for SUNIX Multi-I/O Board device driver Based on
> +	drivers/char/serial.c, parport_pc.c, ppdev.c and lp.c by Linus
> +	Torvalds, Theodore Ts'o.

kconfig does not like those 3 lines above.  That indicates some lack of
testing.

They could be put under "help", but they really should just be deleted or
moved to some source file if you think that they are needed.

> +	help
> +	   Say Y here if you have a SUNIX Multi-IO card.

Indent with tab + 2 spaces, not 3 spaces.

> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called snx.


-- 
~Randy