Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp6486319imb; Fri, 8 Mar 2019 20:37:30 -0800 (PST) X-Google-Smtp-Source: APXvYqwVkfGE9+ZZQgyJCk3R15/5MJORAP/e8tgz6nmVIaSPkMR6vFxGf0mLJRKZvk6W6BMX3X2b X-Received: by 2002:a62:1851:: with SMTP id 78mr22495610pfy.206.1552106249923; Fri, 08 Mar 2019 20:37:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552106249; cv=none; d=google.com; s=arc-20160816; b=npAirwegRZyYKoUSWbSZgsK6r01gGAvuKSnNX1gJOqfY50WvedJA96tzoB3WiS81ac XsAAdtB1cukjRURoo+e8KNXil1Y2TgS2TOOZkMqSaR0z62fg7dkJvGbNl6L4UTQuVPY8 gfYT+ioP513nwOocXZiYhPN7SphqG5tv7YrHJmFd9S/bKAWrjnBG7s8iTAjDVF9MBGVH T8TS1dRGEmzLTrTFtd2FErDAbcchMRBHpbVVtWNH7/+afsFJxKpuPHw9QmqBYLpe5Fjm GlsyFv2JTo3GgSR6ETdgaqkkBjYnZ8PCYINPRPz94+n3M79ZcOfV1CTzLHZf2B5oThNZ NNhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=5EBNWyDGWnAVj4iLKUewwS1+tz2VaAgfJqux1s/2vVY=; b=FgfthDigthaxGjhCELugTqpVrE1zMr7Dw+mwwyhI0xmrsjK8HurCYqh4zF1MdXmeja RtRfAN5vyg/+6YKEiXrpr2ieoLu30DjsKlay4ImNKxWydHh5raEHI5Ks1tP82Ou2c+r4 Fw7QX8K+Wz/AnxDcbgrA4YYawdCpC6Erm5TKaS4Vi1JD2hgBEAxuP/25FvD7fQEH3TQO QDhswXYQCznA5g9tKOXHBGAvDS1ZnM3pNs8zzv93wIBb+2y+R4zbcS4axpJHxSLWYSvG 3F6lsH3BUWtQNJflKI7ChkEi0+3GU5JkM8ymiGE8S1URiykaj6JblKXz6cVBDeD8SwN+ uDRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=o70jP4HM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w8si5866348pgs.302.2019.03.08.20.37.14; Fri, 08 Mar 2019 20:37:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=o70jP4HM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbfCIEgg (ORCPT + 99 others); Fri, 8 Mar 2019 23:36:36 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:44906 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbfCIEgg (ORCPT ); Fri, 8 Mar 2019 23:36:36 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 926C6C54 for ; Sat, 9 Mar 2019 04:36:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id up3SdHqNrerY for ; Fri, 8 Mar 2019 22:36:34 -0600 (CST) Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 659B0C50 for ; Fri, 8 Mar 2019 22:36:34 -0600 (CST) Received: by mail-io1-f69.google.com with SMTP id f10so17322991ioj.9 for ; Fri, 08 Mar 2019 20:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=5EBNWyDGWnAVj4iLKUewwS1+tz2VaAgfJqux1s/2vVY=; b=o70jP4HMLv8o2ZdMnPdJyJG4Juux0D+7xZ8H77QaW0+ANX73lsMiaasD75KkwZeL1i rwJiGVR0E1pz7ZXTlLbxi2YmsYycxv9nh8DG2dApw6zWn/o4zDtKKa4c9ggG4zxUGGCO 3EqKTy9ob7DwzQPdgC8FxfBD04FnhyFfWRtSZ9TyKj9jb+CpXTmEZoxLDHzrJKv1kOFI CPPm1j6bloXOjjgy3l1DX82abgcrJ8Sy74EDnQ29tcq0lBeeV1+DJewDWDRTYeVaTeZJ Hs0fmZYDuEKJRIHbr1KQmiyyvzf/ncVbRq1412cayHWO+KkcwTVaUaFdzyKR8XUzXlTd 0U/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5EBNWyDGWnAVj4iLKUewwS1+tz2VaAgfJqux1s/2vVY=; b=RZ1PLezMbCjLHrrKeZ8+IGkUAh362M+ewAt1DvwOPCSrAlvDttXjuKl3PAyIuY5/+P JOrfNMEjxv5OkONnZwjdoDVXQB4uDIu/MhEpTSLuOMvuK5s9xGJTyekM1L1xopCXcDEU MXtb2v5kjicNI5Lyc49BEowyd8QqWG1hXLYv04bV8vea9q17dqDhnSfyp5t2zFU3cEyR YRcQCRWz1hA6XFgkXSJ/8Q0Gxb0CNqaBMASyl5rx6cgEHEuEXg4kaIQhUhzMcBgKBGOw KbLyPnXUGO/LmWmPbG5IKq2yDy7gR5T0nJakId3YgiEshWr41PYIxarFpmfqQ3aQ7D1y B7iQ== X-Gm-Message-State: APjAAAW2mrjRv9jHZXvAEYeT5YCLBnxig60eGMLKe1p+jax7NI8YqJjp RNIRswtk0yeonovS4lfqWaKG2DGquvWOSNtswEgEFqB+k2tfVkS4B5h9HQHr5kdu+Xj6zXOlbGr UwIV+mvNRa4apQgWmwtp0ADbz0+VJ X-Received: by 2002:a24:45a3:: with SMTP id c35mr9915124itd.37.1552106193968; Fri, 08 Mar 2019 20:36:33 -0800 (PST) X-Received: by 2002:a24:45a3:: with SMTP id c35mr9915118itd.37.1552106193744; Fri, 08 Mar 2019 20:36:33 -0800 (PST) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id o9sm5019911itb.23.2019.03.08.20.36.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 20:36:33 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Rodrigo Siqueira , Haneen Mohammed , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: vkms: check status of alloc_ordered_workqueue Date: Fri, 8 Mar 2019 22:36:27 -0600 Message-Id: <20190309043628.6078-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org alloc_ordered_workqueue may fail and return NULL. The fix returns ENOMEM when it fails to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/gpu/drm/vkms/vkms_crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c index 8a9aeb0a9ea8..bb66dbcd5e3f 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -219,6 +219,8 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, spin_lock_init(&vkms_out->state_lock); vkms_out->crc_workq = alloc_ordered_workqueue("vkms_crc_workq", 0); + if (!vkms_out->crc_workq) + return -ENOMEM; return ret; } -- 2.17.1