Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     kjlu@umn.edu
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <20190309042450.4188-1-kjlu@umn.edu>
Cc:     pakki001@umn.edu, Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20190309042450.4188-1-kjlu@umn.edu>
Message-ID: <155212417408.28502.15628871831122730555@skylake-alporthouse-com>
User-Agent: alot/0.6
Subject: Re: [PATCH] gpu: i915: fix a missing check of get_free_page
Date:   Sat, 09 Mar 2019 09:36:14 +0000
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Kangjie Lu (2019-03-09 04:24:50)
> If the allocation fails, return false to avoid potential
> NULL pointer dereference

No. If we fail to allocate c->tmp, we do uncached reads instead.
-Chris