Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190309015635.5401-1-manivannan.sadhasivam@linaro.org> <20190309015635.5401-2-manivannan.sadhasivam@linaro.org>
In-Reply-To: <20190309015635.5401-2-manivannan.sadhasivam@linaro.org>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Sat, 9 Mar 2019 11:50:57 +0100
Message-ID: <CACRpkdboriy8xym-Czj5g6=3MpiZB8-W45Z62nNQER9S9XsrZQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] amba: Take device out of reset before reading pid and
 cid values
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     Russell King <linux@armlinux.org.uk>,
        Xu Wei <xuwei5@hisilicon.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Peter Griffin <peter.griffin@linaro.org>,
        Guodong Xu <guodong.xu@linaro.org>,
        Haojian Zhuang <haojian.zhuang@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Mar 9, 2019 at 2:59 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:

> For the AMBA Primecell devices having the reset lines wired, it is
> necessary to take them out of reset before reading the pid and cid values.
> Earlier we were dependent on the bootloader to do this but a more cleaner
> approach would be to do it in the kernel itself. Hence, this commit
> deasserts the reset line just before reading the pid and cid values.
>
> Suggested-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

This looks correct to me.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I think you can put it in Russell's patch tracker in some week.

Yours,
Linus Walleij