Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4
To:     Jochen Sprickerhof <jochen@sprickerhof.de>
Cc:     Roger Quadros <rogerq@ti.com>, Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kishon Vijay Abraham I <kishon@ti.com>
From:   Marek Szyprowski <m.szyprowski@samsung.com>
Message-ID: <2b8d7801-26a5-201e-71d1-ccef3c99f728@samsung.com>
Date:   Mon, 11 Mar 2019 12:11:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
        Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190208193505.GA5822@vis>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20190121140204.GA2360@vis> <5C5A9DCB.8040507@ti.com>
        <20190206093830.GS26157@vis>
        <CGME20190206101740epcas2p131674b4b9733047711855ffb2e7a99a7@epcas2p1.samsung.com>
        <5C5AB41C.9080402@ti.com> <bdbce410-7f48-17a5-b58b-3ebd65ca6913@samsung.com>
        <20190208193505.GA5822@vis>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jochen,

On 2019-02-08 20:35, Jochen Sprickerhof wrote:
> Hi Marek,
>
> * Marek Szyprowski <m.szyprowski@samsung.com> [2019-02-08 13:36]:
>>>>> On 21/01/19 16:02, Jochen Sprickerhof wrote:
>>>> [..]
>>>>>> I'm not sure why this it only works with the driver compiled into
>>>>>> the
>>>>>> kernel nor why it needs a hard reset or why it was the line was
>>>>>> dropped
>>>>>> when the patch was accepted. Would be great to get some feedback
>>>>>> of the
>>>>>> authors.
>>>>> When XHCI driver is compiled into the kernel are the relevant PHY
>>>>> drivers
>>>>> compiled in as well?
>>>> Only CONFIG_USB_PHY=y (I took the config from the
>>>> linux-image-4.19.0-1-armmp_4.19.13-1_armhf.deb Debian package as a
>>>> basis where this is the default).
>>
>> I confirm that on Odroid XU4 USB 3.0 works only when all related drivers
>> (dwc3, xhci and exynos5 drd phy) are compiled into the kernel. If they
>> are compiled as modules, USB 3.0 calibration doesn't work. The mentioned
>> patch doesn't fix anything.
>
> I've just tried Linux v5.0-rc5 with the Debian config and
> USB_XHCI_PLATFORM=y and it works, thanks!
>
> Is there a way to make it work with xhci compiled as a module, so it
> would work in Debian out of the box?

One more comment - 5000M mode will also work with everything compiled as
modules (dwc3, exynos5 drd phy and xhci-plat) too. Just make sure that
xhci-plat is loaded before dwc3. This would require some manual
configuration, because autoloading will load xhci-plat after dwc3 probe
and switch to host mode.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland