Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Mar 2019 15:42:28 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc:     Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Per N. Christensen" <pnc@deif.com>, Thomas Winding <twi@deif.com>
Subject: Re: replacement for CAN_LEDS
Message-ID: <20190311144227.GA4404@amd>
References: <729bdb48-8253-282a-2e0b-860ec5ff345c@prevas.dk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF"
Content-Disposition: inline
In-Reply-To: <729bdb48-8253-282a-2e0b-860ec5ff345c@prevas.dk>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--h31gzZEtNLTqOjlF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> I'm in the process of upgrading an old BSP to a 4.19 kernel, and noticed
> that CAN_LEDS has been marked broken. The comments say that the netdev
> trigger can do everything, but doesn't provide much guidance on how to
> actually do the transition.

Seems like something to be improved.

> In my case, I used to have a device tree node
>=20
>                 canb {
>                         label =3D "canb:green:activity";
>                         gpios =3D <&gpio0 5 0>;
>                         default-state =3D "off";
>                         linux,default-trigger =3D "can1-rxtx";
>                 };
>=20
> and if I change the default-trigger to netdev, I get sysfs files in
> /sys/class/leds/canb:green:activity ; if I then echo can1 to device_name
> and 1 to rx,tx, and link, I get the behaviour I used to have.
>=20
> Questions: must this setup be done in userspace like this? Is there some
> udev rule template I could copy? I can also just hardcode the above
> dance in some init script.
>=20
> I'd actually prefer keeping the entire setup in device tree. So would it
> be possible to have netdev_trig_activate() look for some properties in
> the DT node for the led_classdev and populate ->device_name and ->mode
> based on them?

Sounds like good idea. Patch would be welcome...
									Pavel

--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--h31gzZEtNLTqOjlF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlyGc9MACgkQMOfwapXb+vJ9mgCgu8Nk/irs2oazbXlwdhbJ8tWK
jbIAn3YBob59JCCPDWOCuzuFHK6aRsxb
=XRTd
-----END PGP SIGNATURE-----

--h31gzZEtNLTqOjlF--