Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1265240imc; Mon, 11 Mar 2019 09:52:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyulVKtCsCBj1fP7PVw8i2iApF2CpAXJUfHAUduP9DwBvJLv0btXGAf5lPWOYp07PvW8p36 X-Received: by 2002:a62:5385:: with SMTP id h127mr33456572pfb.10.1552323152558; Mon, 11 Mar 2019 09:52:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552323152; cv=none; d=google.com; s=arc-20160816; b=kbbmpAwR+3662F37hqr2XefG9YWUGEjQJzY8mTFewmQp1zKX5FjU1wC8wTMpLeJ+uw tceqW6ygHLDCD94KpGcn9PJaP9U9DieJrDzSjMRz80sV5NytXOIDRNH8EuQ91d9I1VAi udteDHLKhbpB9bZAGsalNvXoD5/i8nYJ1atNbjb+ryr1u5v6b/OUKo0t3ZRHyBbVTLm1 5G7cn5cUqsyWT2B/kG9a28C4RenAj3DtHN6aIB0jEVXjlyTM6R8TWoaCBAD86ucLl52F vE26qQhXQsQHM9rUTLshn5Bhqx62YnPlulkVXPyNRELfpNnZjuB0F/eo+PSf96RyPhbF h+UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=z9dBJ4NwNB62s3bZo7u0/QJA77GvfBIPB9kdw3KAMaY=; b=XoDpsjbfEl/bnxcZYmzonmu/n72Eu7c629o0FdyiXdLWtPycttQSasIst60200B1lP icxOJN75WnDY+1WRXZ8Y8CyaEag+lbzvfUQfv+StJRc2E8qHRb+O83BxeTNKuyh9/qt9 efDT1gvjVfzFidvp1lN5Q/Nkz3z+YkKwaQUO8loEUIkr6SEgfqjtdKnYBL4N6K9gxFjo ABvRb2qn2gNfsuIO0N2+BQa77ZK7tPD8cUQeeATHMqokSM6v8ny8O07KY227/Nr1qMDM RxSFJP2/y61OCcA0Gp7UvwQh4WLLIAAl6CP34wnNNuJNY+86JWAlMPjFOKPYO9E8+2Ms hAyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xOJgdGI0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9si5952972plb.216.2019.03.11.09.52.16; Mon, 11 Mar 2019 09:52:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xOJgdGI0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbfCKQuX (ORCPT + 99 others); Mon, 11 Mar 2019 12:50:23 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38078 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726942AbfCKQuW (ORCPT ); Mon, 11 Mar 2019 12:50:22 -0400 Received: by mail-wm1-f66.google.com with SMTP id a188so4997345wmf.3 for ; Mon, 11 Mar 2019 09:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z9dBJ4NwNB62s3bZo7u0/QJA77GvfBIPB9kdw3KAMaY=; b=xOJgdGI0fsyw6kLv9GBWRaB+HufmWpOcmyV33pdqLNbEkxrY/WUdYrMs5x0/St2EV1 i3fC0eLtOWPeqeemZlfMtD3sc9xOZBgh48DK30MG8Q6QZ3uE+5EZEDu5YOMFdqYcgL1r mrx+n4usHC4+UXD6/D5ZFzRh0qUtmsiluZeIWLalMLvPt1D3r2QStGQBoBq5PrydN5hO 8twuQOuswhmCsewo+922TsLyIPueiCLxYEKCfL+4RmCLc9yjkgA+iPci/IPPKhiOkg13 gvmNyu+Suc6tU4Q6kKPDZbAzxXunGdsMrBb6ymn8UjF0rDdab8qwUm2F93h1SWGqnxeE 3mqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z9dBJ4NwNB62s3bZo7u0/QJA77GvfBIPB9kdw3KAMaY=; b=nlh3flw1ObiqpjG9wD2ZbDH0msVH6htxbjp6/FBjOwF8c+AIWUk76MOoWUtEpxJmjg hqS74FdqHzwDMFbN/3nqealVUjCDAfiz+iJSfVzAq4p2FOMSwcItGTBAKaOKXKFVJYnT sed7j5WPTKrrjHhjVzt+cKUrQ72zHrtmUnaBgxP2GXwCco1qvUc7svnO4/ZksQYEzOjw IvDiZZ0eg3Tk8jECocDJBD63gYQIvIkjXkpRNGz8UPAuIQPeowE2m8fqygCk7RkGiuFH Qvqi4MIh1Ga1kOfr387AJZJARYaP/bvZ1woUjubhK2exqcCCcR9NYZ6kDYquCnFpVbUM o7uQ== X-Gm-Message-State: APjAAAWWi6xclHodBVU7yj/BnHvcH9DmnL+lF4s2hKygcy0YNkMgA9LZ SyjFekWU9YFa14oStr/2i7fkSfDiiUEtOFUdxM3dSg== X-Received: by 2002:a1c:80c4:: with SMTP id b187mr395918wmd.23.1552323020672; Mon, 11 Mar 2019 09:50:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: John Stultz Date: Mon, 11 Mar 2019 09:50:08 -0700 Message-ID: Subject: Re: REGRESSION: dwc2: gadget: Add scatter-gather mode To: Marek Szyprowski Cc: Felipe Balbi , Minas Harutyunyan , Artur Petrosyan , Linux USB List , lkml , Tom Gall , Andrzej Hajda , Andrzej Pietrasiewicz Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 11, 2019 at 3:15 AM Marek Szyprowski wrote: > > Hi John > > > On 2019-03-08 21:53, John Stultz wrote: > > Hey Andrzej, > > I just wanted to let you know, trying to boot linus/master on the > > hikey board today, I've been seeing lots of errors on boot (which > > sometimes crash the board, and sometimes doesn't). See the example > > below. > > > > I've bisected the issue down to 10209abe87f5 ("usb: dwc2: gadget: Add > > scatter-gather mode"), and if I revert that change the issue goes > > away. > > > > Looking at the patch, I can't see anything obviously sticking out, but > > let me know if you have anything suggestions you'd like me to test. > > I've CCed new Andrzej's email. > > Could you tell a bit more how to reproduce this issue? Which USB > function are you running on the target system? I've noticed that you are > using functionfs. Is is possible to get access to the usb function > daemon to reproduce the problem here? Which version of HiKey board are > you using? So this is on a LeMaker HiKey (2gb ram 8gb storage), running AOSP (so its adbd that is the ffs daemon) I have a mainline tracking tree which follows mainline here to provide MALI gpu and other android requirements: https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/hikey-mainline-WIP I'm traveling this week, but if you really want to reproduce this yourself you can grab the system/vendor/boot images here: https://snapshots.linaro.org/96boards/hikey/linaro/aosp-master/latest/ Then build the kernel w/ the hikey_defconfig and replace the kernel image in boot.img w/ the abootimg tool. Let me know if you have any trouble and I can try to help walk you through it. thanks -john