Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1270902imc; Mon, 11 Mar 2019 10:00:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwR0B3PZbLN56OJMHHukJFfhn1hRGa9V7iXLNOz/i3fzFvQizNVd8dg5JzzVuerB+BGFNR7 X-Received: by 2002:a62:e40d:: with SMTP id r13mr33512578pfh.11.1552323600263; Mon, 11 Mar 2019 10:00:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552323600; cv=none; d=google.com; s=arc-20160816; b=zb8jrtnb6A0XSIlwIoU8gFv56CnsZ+2G33r3RaRLAkPO8upHeTNApPzaU0vu1NxAot pxHSazRQbxwC3HspE2PBDDQrxT14R+EdLDifbY4N2R1kUjFm7zI945s7yXJsNQi7FRax D+EnOwwHwbIZ1d0DgtDGxzDSe8PTg9fy5PzMdFf5A3+5DRZTCQl1cQ+4QzXRb0e6HyK2 O50eqsGuEJhL+BQkd54l8YPXKO+D7ExyMU930RzJNDimkJKoWIlIez2LOC01bDXCLFvF ZnyBJb6aEUvWX3+sx43B22aS7IX+WPrdrYw2jWvPo8POIkjHzIBBm/Bhnk/31LRppoj1 dGRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=+xQVHgMf1N5RM9VdEebWxCnIE6iW4bt4/5KDAOHmBKI=; b=yw5DwvIQWucdau6EGiKg5vTgWkQ3AwQdstUUd8Qdm9ns7vmavpDrsjiJwssGl3B5QS jxF2cHx67DdmNQd22HcSOI3mqrRE1UZS5ca+VOcR/nENHbIAexkDL6jPyb0kroZ1JJZW z4rR6w03odrYdVa0YwQGyZQ4g7GIa+EVjgO2lG9QnTe4/Azc7Xnyp7QOChhprqKIppXk AtyIjcnYlOxzQjVMBq9kgjLSCYovF3VYXHAmLSBGUt48WZEvPCAbMg8onEi4TgbAVyTp 9166GaxXarmLhLswYUDtXMC7tyzNY8FWK4jZJL5QbL1W06/7zflwpoYv0bmwjEf0oxQ3 s3DQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 73si5827579pld.156.2019.03.11.09.59.44; Mon, 11 Mar 2019 10:00:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727532AbfCKQ7S convert rfc822-to-8bit (ORCPT + 99 others); Mon, 11 Mar 2019 12:59:18 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:32903 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726675AbfCKQ7R (ORCPT ); Mon, 11 Mar 2019 12:59:17 -0400 Received: from LHREML712-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 6D7D4F457CD0D9C76349; Mon, 11 Mar 2019 16:59:15 +0000 (GMT) Received: from fraeml701-chm.china.huawei.com (10.206.15.50) by LHREML712-CAH.china.huawei.com (10.201.108.35) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 11 Mar 2019 16:59:15 +0000 Received: from fraeml704-chm.china.huawei.com (10.206.15.53) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 11 Mar 2019 18:59:14 +0200 Received: from fraeml704-chm.china.huawei.com ([10.206.112.182]) by fraeml704-chm.china.huawei.com ([10.206.112.182]) with mapi id 15.01.1591.008; Mon, 11 Mar 2019 18:59:14 +0200 From: Dmitry Kasatkin To: Al Viro , yuehaibing CC: "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "keescook@chromium.org" , "stable@vger.kernel.org" , "gregkh@google.com" Subject: Re: [PATCH -next] exec: Fix mem leak in kernel_read_file Thread-Topic: [PATCH -next] exec: Fix mem leak in kernel_read_file Thread-Index: AQHUx/hXfkWBsNi2tEKokiQlVrf8Y6XmQzYAgCCDsbc= Date: Mon, 11 Mar 2019 16:59:14 +0000 Message-ID: References: <20190219021038.11340-1-yuehaibing@huawei.com>,<20190219022512.GW2217@ZenIV.linux.org.uk> In-Reply-To: <20190219022512.GW2217@ZenIV.linux.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.122.225.32] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro on behalf of Al Viro Sent: Tuesday, February 19, 2019 4:25 AM To: yuehaibing Cc: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; Dmitry Kasatkin; keescook@chromium.org Subject: Re: [PATCH -next] exec: Fix mem leak in kernel_read_file ? On Tue, Feb 19, 2019 at 10:10:38AM +0800, YueHaibing wrote: > syzkaller report this: > BUG: memory leak > unreferenced object 0xffffc9000488d000 (size 9195520): >?? comm "syz-executor.0", pid 2752, jiffies 4294787496 (age 18.757s) >?? hex dump (first 32 bytes): >???? ff ff ff ff ff ff ff ff a8 00 00 00 01 00 00 00? ................ >???? 02 00 00 00 00 00 00 00 80 a1 7a c1 ff ff ff ff? ..........z..... >?? backtrace: >???? [<000000000863775c>] __vmalloc_node mm/vmalloc.c:1795 [inline] >???? [<000000000863775c>] __vmalloc_node_flags mm/vmalloc.c:1809 [inline] >???? [<000000000863775c>] vmalloc+0x8c/0xb0 mm/vmalloc.c:1831 >???? [<000000003f668111>] kernel_read_file+0x58f/0x7d0 fs/exec.c:924 >???? [<000000002385813f>] kernel_read_file_from_fd+0x49/0x80 fs/exec.c:993 >???? [<0000000011953ff1>] __do_sys_finit_module+0x13b/0x2a0 kernel/module.c:3895 >???? [<000000006f58491f>] do_syscall_64+0x147/0x600 arch/x86/entry/common.c:290 >???? [<00000000ee78baf4>] entry_SYSCALL_64_after_hwframe+0x49/0xbe >???? [<00000000241f889b>] 0xffffffffffffffff > > It should goto 'out_free' lable to free allocated buf while kernel_read > fails. Applied. This must be applied to stables as well...