Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Mar 2019 14:49:58 -0300
From:   Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To:     Gerd Hoffmann <kraxel@redhat.com>
Cc:     David Airlie <airlied@linux.ie>,
        virtualization@lists.linux-foundation.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper
Message-ID: <20190311174958.xdw4lrvf6ydeplvc@smtp.gmail.com>
References: <20190310212150.xhhb4abzm7j3ain2@smtp.gmail.com>
 <20190311062200.4mtel3j5fjxtxrcf@sirius.home.kraxel.org>
 <20190311101159.t6mbzm5sdwuh5muc@smtp.gmail.com>
 <20190311130716.6hjqci43clic5lxx@sirius.home.kraxel.org>
 <20190311132358.GF2665@phenom.ffwll.local>
 <20190311133919.azyhtioxf23duf3g@sirius.home.kraxel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dzkdplsu5vlzb5xc"
Content-Disposition: inline
In-Reply-To: <20190311133919.azyhtioxf23duf3g@sirius.home.kraxel.org>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--dzkdplsu5vlzb5xc
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 03/11, Gerd Hoffmann wrote:
>   Hi,
>=20
> > > IIRC the drm code checks for the atomic_enable callback presence to
> > > figure whenever it should take the atomic or legacy code paths.
> >=20
> > It should check for drm_driver->mode_config.funcs.atomic_commit for tha=
t,
> > see drm_drv_uses_atomic_modeset(). Anything else should be a bug.
> >=20
> > Or do you mean the fallback to the old crtc helper prepare/commit
> > callbacks?
>=20
> Probably the later.  There was some reason why I've left in the empty
> bochs_crtc_atomic_enable() callback ...

Just for checking before I start to work in this patch:
The correct solution should be made atomic_enable and atomic_disable
optional, right? I should do it, and check if Bochs driver really needs
bochs_crtc_atomic_enable after my change, right?

> cheers,
>   Gerd
>=20

--=20
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of S=E3o Paulo

--dzkdplsu5vlzb5xc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4tZ+ii1mjMCMQbfkWJzP/comvP8FAlyGn8YACgkQWJzP/com
vP+WBhAAr1M8k6aerbm1C1ux/iLe6mX3ju4QPdRP/uCgqw6pWgtTWeVCPCSOHVUe
q9VWmQ6GHV0+lAzN1EurEMi8M6ofPXgQS1GocEhw8lX9YeiUC/60LrgqhvrGVaJ2
qARnXUY6bAHCQeXebNjw6smlIFSAtTzVMYbuDnlvSZe21nW0Et1nubvEVj6JHWbW
cFu+VTJtHCb6ty+HJIeBBKbMK6hP1P6Vi1E6UrG4uKxhM9nb2omlpvNhFSMVWmcg
PSUvg6MkJxSmX3+9UU4sdDPV728k8M2aePlouOwqQE5IXudlSgZu9bOz8kpr5+GP
mD9Sd+3Wcr/8aZEWfLpHN6PdjffqwL55BHg3qE/XND+I1T8paRTIdwE0Rbig8LzN
Fw7hlbo7TD+/zvVscDI+mJcDhTD4cLf0IEq70OcCam+AjcGefTmrO/ygPAinKPBz
DrbsdYWtrtDYiWTPP7E8YWVBhOXeVDhk0vmcHxwsLznE0klk4j8bGauN6rZ88b2o
7Qoqsstnyi3G5aGtVR1u/NZmSkN17687zmCAu0SHfUwTKoCBSV1M6P8o54VbuL9p
IvUSNVOLDPzpg85jZRyy44Wy4kyFosGDTzuDcoPcu+j3JVWg7J/XtCfu+zP8yYza
PCgw1hrWzgdCwWTBtGYhRv5hY5hjBjoev2GvGKons0gUX8j0/68=
=hsIt
-----END PGP SIGNATURE-----

--dzkdplsu5vlzb5xc--