Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1392082imc; Mon, 11 Mar 2019 12:44:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqyk1AuvEHAxYpc1HMfkuZgnL7CcskFIOrA8JAa8Yjc4OeVHP2nfT4BuFrhr1HN9LUcmZvTC X-Received: by 2002:a63:fe0d:: with SMTP id p13mr30464925pgh.366.1552333450944; Mon, 11 Mar 2019 12:44:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552333450; cv=none; d=google.com; s=arc-20160816; b=JjO+Dcl5gHFqja9kW7hQuDu6agBPjDHlskiDX9MRrE8dTO1RzcgMehETo1jRCY7gDj DcxnpkmEkDMhO8wvBXjRBYfneJxgIVfxAXdx/OJOxcomEIYS+6R0qQA16wFHG9wyf5gb ipVVFVCy3vwJ7qXeowUd8KfrhfbbDkJvZ/hLJxTJSEcdpB2NkzYAPBY0U4Lu9sFMXfuO 9nqrhAY+yGFk8UouYZojYRq2cPVzvGqF2a+37adi7cHUXE94Q9jEHsweu/A/jbMxseSo 7/kmTpsXUaOdEt+hPkXLdy8IWzWDD1/KTKJiiQPGqGhQEFRChuFhb222jgZL4ALqjiKL 6cAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1GssAwpnYXm30bkDNRQCM92y9rXKjcTayGfEnVUIfek=; b=OS10+3QJhY4Tb52RCjyuN627lroUZYrZMxF91NxyEcaoYcWkZ/LCrrlVo4ITTp5xvK OtAmBCR7LSRRmIxwWlw14iIQLvhLWFtZihUSuPU4Y3TWHesipr7VyFo6ARLFy58u93nh e3qthQU9+uFGmy5tVVWCIwLZZPQmyiaMAlth1fyzoMlCcs6cnCAjRz8f85TIo6sGOpI9 qVXLMcxt4UbDZINZWQSRZERahyUedW3o3y3cwefcH3lSVc4F0AzEvvBOLZjRi+KDSCNV tSfSFw2Px48LOoehpMXZgZy6mz5N+ltPyV3vrLeKRRriZQ+X+yL0naoXWSl+kwgMJ47E wVsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2si5622877pgp.549.2019.03.11.12.43.55; Mon, 11 Mar 2019 12:44:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728138AbfCKTnM (ORCPT + 99 others); Mon, 11 Mar 2019 15:43:12 -0400 Received: from verein.lst.de ([213.95.11.211]:43172 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727027AbfCKTnM (ORCPT ); Mon, 11 Mar 2019 15:43:12 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 871A868C7B; Mon, 11 Mar 2019 20:43:06 +0100 (CET) Date: Mon, 11 Mar 2019 20:43:06 +0100 From: Christoph Hellwig To: Al Viro Cc: Linus Torvalds , Eric Dumazet , David Miller , Jason Baron , kgraul@linux.ibm.com, ktkhai@virtuozzo.com, kyeongdon.kim@lge.com, Linux List Kernel Mailing , Netdev , pabeni@redhat.com, syzkaller-bugs@googlegroups.com, xiyou.wangcong@gmail.com, Christoph Hellwig , zhengbin , bcrl@kvack.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, houtao1@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH 2/8] keep io_event in aio_kiocb Message-ID: <20190311194306.GC12602@lst.de> References: <20190310070606.GA10138@ZenIV.linux.org.uk> <20190310070822.11564-1-viro@ZenIV.linux.org.uk> <20190310070822.11564-2-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190310070822.11564-2-viro@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 10, 2019 at 07:08:16AM +0000, Al Viro wrote: > From: Al Viro > > Signed-off-by: Al Viro This could use a little changelog at least that explains the why. It also removes lookup_kiocb and folds that into the only caller, which is at least worth mentioning (and probably should be a separate patch).