Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1409227imc; Mon, 11 Mar 2019 13:08:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqyi1tHGfy4PCjNLmj0o0NWABoTblHVqbKmWA26XXB5Q8gxSfNKsfOVnvWqI6QAPHFnv1RWQ X-Received: by 2002:a17:902:b617:: with SMTP id b23mr7740269pls.200.1552334916548; Mon, 11 Mar 2019 13:08:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552334916; cv=none; d=google.com; s=arc-20160816; b=AiBYNTrb7XEnyhJVwtU2kX+7LhSvnKGyfzwf1zy0B5d9rQq+DWR6T30dEh/h72kz5Q SvWDOfj4d46ugfDFmEem2XtaaOvasENbevfpj0GgObKquvH5DT2N0U2F6bS/GI0kUrJs 6cTODk9jQ7k9gcbCahITqRPlU0Z/aRP0AnwWaFOjz5WkIoZcAHPfpTpyoTNLBuDH/kpb B4vnYBWvb+EGerogT4nxJa1Cu8ipmTonRh/w7fI5CXiXCi52UQLsSr+7t8G4nB1dCNSi jBAKAhYw12FtIuVNmCqjpvkkvG/Axwi3PbqHg/OyHvkTtUxNrSjk6l9m1Es/aESdBjg3 da5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:smtp-origin-cluster:cc:to :smtp-origin-hostname:from:smtp-origin-hostprefix:dkim-signature; bh=sVfnnivnzEIimgfiP0sMl6h8ahaCueFgUWIsxsMb0+0=; b=R4OHUg/mYtzF28a3VslyuryNtNRDP5MkVlZUXFor5ZyLvGQa382N3rzu6NGLi7iQD7 jElgYhrl+ahUUtptmBgB2OdKM6YmRkXG6LKOHTn1RCtFT/Z2jBNIYL1rdrq51/Y+IEHs PddYkWjcO4Hm8UNnqVUqR0pLLqNaVVXclyrMAFrfT5nLpo++7pum5YRJrk7s39zY8jHc uCWs+wAFx03g+7z+cmO3XHH3bk++X15NkqQiZbHOrUa1R72jbXwtrYTIglb8YhikWAxw 3+gmF3SrcrSHTbU8Rfm4awR/R0CE3edGeJvcblKBKDkbsfSSWl0nZTAGbcTUDnk4bnQt nOHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=GENumiI4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si6142801pfb.153.2019.03.11.13.08.20; Mon, 11 Mar 2019 13:08:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=GENumiI4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729257AbfCKUID (ORCPT + 99 others); Mon, 11 Mar 2019 16:08:03 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:40956 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729014AbfCKT5U (ORCPT ); Mon, 11 Mar 2019 15:57:20 -0400 Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2BJsUKY024482 for ; Mon, 11 Mar 2019 12:57:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=facebook; bh=sVfnnivnzEIimgfiP0sMl6h8ahaCueFgUWIsxsMb0+0=; b=GENumiI4BFgBBkrpwKPu2I4on9QKSJEOf1tlW3sGoWCjHD5SSl24xSA+icZ7vaR/JaS1 QfHbI9shWhyuDJY4L7QrnKFfZ2zrD8VF5/jqdoaby6LrU6/YO1kOGKBOd0OQI+2D99qk Wfbrb9cSW+Hhl8ZdSX9FyTOLi8j4ccAMRIk= Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0a-00082601.pphosted.com with ESMTP id 2r5wuw82xe-13 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 11 Mar 2019 12:57:19 -0700 Received: from mx-out.facebook.com (2620:10d:c0a1:3::13) by mail.thefacebook.com (2620:10d:c021:18::172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5; Mon, 11 Mar 2019 12:56:36 -0700 Received: by devbig006.ftw2.facebook.com (Postfix, from userid 4523) id 2174362E1B7E; Mon, 11 Mar 2019 12:56:36 -0700 (PDT) Smtp-Origin-Hostprefix: devbig From: Song Liu Smtp-Origin-Hostname: devbig006.ftw2.facebook.com To: , , CC: , , , , , , , , Song Liu Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH v8 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data Date: Mon, 11 Mar 2019 12:55:49 -0700 Message-ID: <20190311195555.889995-10-songliubraving@fb.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190311195555.889995-1-songliubraving@fb.com> References: <20190311195555.889995-1-songliubraving@fb.com> X-FB-Internal: Safe MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-11_15:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch enables perf-record to save btf information as headers to perf.data A new header type HEADER_BPF_BTF is introduced for this data. Signed-off-by: Song Liu --- tools/perf/util/header.c | 101 ++++++++++++++++++++++++++++++++++++++- tools/perf/util/header.h | 1 + 2 files changed, 101 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index e53ee3111430..e5a86b9f68db 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -1118,6 +1118,39 @@ static int write_bpf_prog_info(struct feat_fd *ff, return ret; } +static int write_bpf_btf(struct feat_fd *ff, + struct perf_evlist *evlist __maybe_unused) +{ + struct perf_env *env = &ff->ph->env; + struct rb_root *root; + struct rb_node *next; + int ret; + + down_read(&env->bpf_progs.lock); + + ret = do_write(ff, &env->bpf_progs.btfs_cnt, + sizeof(env->bpf_progs.btfs_cnt)); + + if (ret < 0) + goto out; + + root = &env->bpf_progs.btfs; + next = rb_first(root); + while (next) { + struct btf_node *node; + + node = rb_entry(next, struct btf_node, rb_node); + next = rb_next(&node->rb_node); + ret = do_write(ff, &node->id, + sizeof(u32) * 2 + node->data_size); + if (ret < 0) + goto out; + } +out: + up_read(&env->bpf_progs.lock); + return ret; +} + static int cpu_cache_level__sort(const void *a, const void *b) { struct cpu_cache_level *cache_a = (struct cpu_cache_level *)a; @@ -1621,6 +1654,28 @@ static void print_bpf_prog_info(struct feat_fd *ff, FILE *fp) up_read(&env->bpf_progs.lock); } +static void print_bpf_btf(struct feat_fd *ff, FILE *fp) +{ + struct perf_env *env = &ff->ph->env; + struct rb_root *root; + struct rb_node *next; + + down_read(&env->bpf_progs.lock); + + root = &env->bpf_progs.btfs; + next = rb_first(root); + + while (next) { + struct btf_node *node; + + node = rb_entry(next, struct btf_node, rb_node); + next = rb_next(&node->rb_node); + fprintf(fp, "# btf info of id %u\n", node->id); + } + + up_read(&env->bpf_progs.lock); +} + static void free_event_desc(struct perf_evsel *events) { struct perf_evsel *evsel; @@ -2722,6 +2777,49 @@ static int process_bpf_prog_info(struct feat_fd *ff, return err; } +static int process_bpf_btf(struct feat_fd *ff, void *data __maybe_unused) +{ + struct perf_env *env = &ff->ph->env; + u32 count, i; + + if (ff->ph->needs_swap) { + pr_warning("interpreting btf from systems with endianity is not yet supported\n"); + return 0; + } + + if (do_read_u32(ff, &count)) + return -1; + + down_write(&env->bpf_progs.lock); + + for (i = 0; i < count; ++i) { + struct btf_node *node; + u32 id, data_size; + + if (do_read_u32(ff, &id)) + return -1; + if (do_read_u32(ff, &data_size)) + return -1; + + node = malloc(sizeof(struct btf_node) + data_size); + if (!node) + return -1; + + node->id = id; + node->data_size = data_size; + + if (__do_read(ff, node->data, data_size)) { + free(node); + return -1; + } + + perf_env__insert_btf(env, node); + } + + up_write(&env->bpf_progs.lock); + return 0; +} + struct feature_ops { int (*write)(struct feat_fd *ff, struct perf_evlist *evlist); void (*print)(struct feat_fd *ff, FILE *fp); @@ -2782,7 +2880,8 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = { FEAT_OPR(SAMPLE_TIME, sample_time, false), FEAT_OPR(MEM_TOPOLOGY, mem_topology, true), FEAT_OPR(CLOCKID, clockid, false), - FEAT_OPR(BPF_PROG_INFO, bpf_prog_info, false) + FEAT_OPR(BPF_PROG_INFO, bpf_prog_info, false), + FEAT_OPR(BPF_BTF, bpf_btf, false) }; struct header_print_data { diff --git a/tools/perf/util/header.h b/tools/perf/util/header.h index 0785c91b4c3a..9e7d931f7c0d 100644 --- a/tools/perf/util/header.h +++ b/tools/perf/util/header.h @@ -40,6 +40,7 @@ enum { HEADER_MEM_TOPOLOGY, HEADER_CLOCKID, HEADER_BPF_PROG_INFO, + HEADER_BPF_BTF, HEADER_LAST_FEATURE, HEADER_FEAT_BITS = 256, }; -- 2.17.1