Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1411989imc; Mon, 11 Mar 2019 13:12:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLXjADw/Q3anzjHqSHCAxvMt8SGi9O46MBNbt0iakp7f7gqZabEmN+o0xO2YObtd4Og6Hs X-Received: by 2002:a63:494e:: with SMTP id y14mr15694111pgk.225.1552335130093; Mon, 11 Mar 2019 13:12:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552335130; cv=none; d=google.com; s=arc-20160816; b=VxyLNPdzy1P0Ag3wlcJLlezI5jFR+N4Q0m2dtU6Ns1heMsR0R1IBRfLTEkVFmYFG6m zdTm4TKxTB6iHLooWkJSFaB635bFOKy1R9cufXf5AHYHl4Bc4P/PF7mAvFkgWrsx/zlJ +DEmYCd9sbZYqWIsRlxhHu3ZwvFMUkklqeH0qbgiqnT0Un7mNqCtDsN8vAmR7wa4m/GZ mVQV3fXxr/g8mzTHsMw5L6sbOB5ZPneoL/C1KnK1kVnCADzx05FEeewKPTmv8ElgFE9e tnwX0kuVjkox5/OhFilKpdiNeb4cPob2Ncvo8XvBBgU0f3OK/9c22x7+lSKfg3a3qVZM AEbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:smtp-origin-cluster:cc:to :smtp-origin-hostname:from:smtp-origin-hostprefix:dkim-signature; bh=YD+fcm/fusDClh4H7LLxV82JlUR6M6cXHEgXwK9hXPY=; b=uiC2rFedoT1aJ/2Gvknz3f3NrI9JKehlJNJvtaPhZ+1ZZnH1UYipjcejUm2mNfZ9Iz ImolPE540TjrPgFp05GwQ1LEXIDpqe7LAs1wm1sIlRoz4JqMQt4lw+TzhyFI/Mqaa6+l 7818G28gw16Z4cuSZ6LgZYhxYs5R2HAF1u+UEOMOF4ArvRd6YBzq9Fr5bO0DhvEkKKRL BdJF8zvUY5Vj3e3sEwxEPX0TYOjxPbQDhSOjLOh2zgsuCCogu0DT+i5mvso4VplHdwXI ggFH2f/oKoY+ZWzFpzAW+ks2PuySxmzJaViFaoMv1yrpC9LRLUWU5jMQCKhQGl5GIaXp HuEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=O8SEHwfj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay10si6076326plb.372.2019.03.11.13.11.54; Mon, 11 Mar 2019 13:12:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=O8SEHwfj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728774AbfCKT4g (ORCPT + 99 others); Mon, 11 Mar 2019 15:56:36 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:51374 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728730AbfCKT4b (ORCPT ); Mon, 11 Mar 2019 15:56:31 -0400 Received: from pps.filterd (m0001255.ppops.net [127.0.0.1]) by mx0b-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2BJt3m4013633 for ; Mon, 11 Mar 2019 12:56:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=facebook; bh=YD+fcm/fusDClh4H7LLxV82JlUR6M6cXHEgXwK9hXPY=; b=O8SEHwfjOeeo51QxkevM4zt3WSCIgH3Znv1IpcHkIM3GB7Jusg2S2IIMa5Q4mv6zSkj+ u7iCjVacnutAJJnRSGhAE1uNhmHGprgQhtclzX5xdLsegtuq//AKN3rbVSngYk85UixJ 2bIaAmid9yQS7R5t2PN4ZFsmcBq3f7rQpuk= Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0b-00082601.pphosted.com with ESMTP id 2r5vc4rexd-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 11 Mar 2019 12:56:31 -0700 Received: from mx-out.facebook.com (2620:10d:c0a1:3::13) by mail.thefacebook.com (2620:10d:c021:18::176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5; Mon, 11 Mar 2019 12:56:28 -0700 Received: by devbig006.ftw2.facebook.com (Postfix, from userid 4523) id AFDC162E1B7E; Mon, 11 Mar 2019 12:56:27 -0700 (PDT) Smtp-Origin-Hostprefix: devbig From: Song Liu Smtp-Origin-Hostname: devbig006.ftw2.facebook.com To: , , CC: , , , , , , , , Song Liu Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH v8 perf,bpf 05/15] perf: change prototype of perf_event__synthesize_bpf_events() Date: Mon, 11 Mar 2019 12:55:45 -0700 Message-ID: <20190311195555.889995-6-songliubraving@fb.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190311195555.889995-1-songliubraving@fb.com> References: <20190311195555.889995-1-songliubraving@fb.com> X-FB-Internal: Safe MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-11_14:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch changes the arguments of perf_event__synthesize_bpf_events() to include perf_session* instead of perf_tool*. perf_session will be used in the next patch. Signed-off-by: Song Liu --- tools/perf/builtin-record.c | 2 +- tools/perf/builtin-top.c | 2 +- tools/perf/util/bpf-event.c | 8 +++++--- tools/perf/util/bpf-event.h | 4 ++-- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 88ea11d57c6f..2355e0a9eda0 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -1083,7 +1083,7 @@ static int record__synthesize(struct record *rec, bool tail) return err; } - err = perf_event__synthesize_bpf_events(tool, process_synthesized_event, + err = perf_event__synthesize_bpf_events(session, process_synthesized_event, machine, opts); if (err < 0) pr_warning("Couldn't synthesize bpf events.\n"); diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 5a486d4de56e..27d8d42e0a4d 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1216,7 +1216,7 @@ static int __cmd_top(struct perf_top *top) init_process_thread(top); - ret = perf_event__synthesize_bpf_events(&top->tool, perf_event__process, + ret = perf_event__synthesize_bpf_events(top->session, perf_event__process, &top->session->machines.host, &top->record_opts); if (ret < 0) diff --git a/tools/perf/util/bpf-event.c b/tools/perf/util/bpf-event.c index e6dfb95029e5..ff7ee149ec46 100644 --- a/tools/perf/util/bpf-event.c +++ b/tools/perf/util/bpf-event.c @@ -10,6 +10,7 @@ #include "debug.h" #include "symbol.h" #include "machine.h" +#include "session.h" #define ptr_to_u64(ptr) ((__u64)(unsigned long)(ptr)) @@ -42,7 +43,7 @@ int machine__process_bpf_event(struct machine *machine __maybe_unused, * -1 for failures; * -2 for lack of kernel support. */ -static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool, +static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, perf_event__handler_t process, struct machine *machine, int fd, @@ -52,6 +53,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool, struct ksymbol_event *ksymbol_event = &event->ksymbol_event; struct bpf_event *bpf_event = &event->bpf_event; struct bpf_prog_info_linear *info_linear; + struct perf_tool *tool = session->tool; struct bpf_prog_info *info; struct btf *btf = NULL; bool has_btf = false; @@ -175,7 +177,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool, return err ? -1 : 0; } -int perf_event__synthesize_bpf_events(struct perf_tool *tool, +int perf_event__synthesize_bpf_events(struct perf_session *session, perf_event__handler_t process, struct machine *machine, struct record_opts *opts) @@ -209,7 +211,7 @@ int perf_event__synthesize_bpf_events(struct perf_tool *tool, continue; } - err = perf_event__synthesize_one_bpf_prog(tool, process, + err = perf_event__synthesize_one_bpf_prog(session, process, machine, fd, event, opts); close(fd); diff --git a/tools/perf/util/bpf-event.h b/tools/perf/util/bpf-event.h index 7890067e1a37..6698683612a7 100644 --- a/tools/perf/util/bpf-event.h +++ b/tools/perf/util/bpf-event.h @@ -15,7 +15,7 @@ struct record_opts; int machine__process_bpf_event(struct machine *machine, union perf_event *event, struct perf_sample *sample); -int perf_event__synthesize_bpf_events(struct perf_tool *tool, +int perf_event__synthesize_bpf_events(struct perf_session *session, perf_event__handler_t process, struct machine *machine, struct record_opts *opts); @@ -27,7 +27,7 @@ static inline int machine__process_bpf_event(struct machine *machine __maybe_unu return 0; } -static inline int perf_event__synthesize_bpf_events(struct perf_tool *tool __maybe_unused, +static inline int perf_event__synthesize_bpf_events(struct perf_session *session __maybe_unused, perf_event__handler_t process __maybe_unused, struct machine *machine __maybe_unused, struct record_opts *opts __maybe_unused) -- 2.17.1