Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1430534imc; Mon, 11 Mar 2019 13:39:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9mJ1QXF1GpqOGyMaX2EiYL/RuWWk6Z54AGGVMsKFgAd95J0glb021u73PMkKYS+OGTENf X-Received: by 2002:a63:d04f:: with SMTP id s15mr14031335pgi.80.1552336794955; Mon, 11 Mar 2019 13:39:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552336794; cv=none; d=google.com; s=arc-20160816; b=go/d9ntlgURFUlGf6CgnShvT2hP0Ej5XoeDPPMLcGLRU+uGYJEnpaUjo1chhLoGSZ7 vDSC4lp4u/dcHDXfjYNEtu9vXNztpexxeMa3bTjwhaM9GQlvvhGj8DnntkmRGiKBUppt A2U/Ofiw/FbkDN6wKxX2U191b6bk4D7ffOTUHxkMirBxXomMp/p1THlFYarXsCvpGHSc A1rE8dzloePn0KFI2QICNpno+twJ4t5h1BsyhwlkQ3T9KJNkxcg1Ecq18MVvUaJk7nEs z/tj1JnlRWNO7xsFe94NWuwwc7RO2tljbkxFQEpRkasiZohyW0oUa2LyxYDn3FUrB9iV kUlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=mFfn0gDYHcVIoZSEaoUouoSk7MGtsgperZT7o7uFIpI=; b=anzmAtmY0+Qry0hJ0BnGRZ+jmEPBnw+B5VxPZgvxruBQvg2voL6fKf6xVv9JWA1F27 0DTWyE0jfYea9AmlYYNOEZq0dnsZSUDKiaDLHBg3v/LWbdueIXoPnJr6ckoVp0MBOGca rCqheefpqPK1TxGrjQgILrpY+Ao/0b1F/ysKN4PZbRm7ETgFOzgUJFrJ2fMa6MTwIewd RErfxnf5MvWCOdnC68piFmPtYVFtQ6OXHU9LxPGmZ3g1EDq3eXITmf6xrhDxEMv3UOun CtH3mXu1u9QPwMQw/LP9zsTEUOlXw9l1TxtHosIVAHs/FuLBxcuSlWlpBGmEYwYQuZ0D n6Vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n20si5825730pfi.226.2019.03.11.13.39.38; Mon, 11 Mar 2019 13:39:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728250AbfCKUik (ORCPT + 99 others); Mon, 11 Mar 2019 16:38:40 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41410 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726675AbfCKUij (ORCPT ); Mon, 11 Mar 2019 16:38:39 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 48D5514C6835E; Mon, 11 Mar 2019 13:38:39 -0700 (PDT) Date: Mon, 11 Mar 2019 13:38:38 -0700 (PDT) Message-Id: <20190311.133838.74958847820887089.davem@davemloft.net> To: kjlu@umn.edu Cc: pakki001@umn.edu, saeedm@mellanox.com, leon@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mlx5: fix a potential NULL pointer dereference From: David Miller In-Reply-To: <20190311063343.20188-1-kjlu@umn.edu> References: <20190311063343.20188-1-kjlu@umn.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Mar 2019 13:38:39 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu Date: Mon, 11 Mar 2019 01:33:43 -0500 > In case skb_header_pointer fails, the fix issues a warning. > > A better fix requires modifying the signature of mlx5e_get_fcs to > pass an error code upstream. > > Signed-off-by: Kangjie Lu Saeed, I'll let you take this. Thanks.