Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Mar 2019 13:42:17 -0700
From:   "Luck, Tony" <tony.luck@intel.com>
To:     "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc:     Borislav Petkov <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH] x86, mce: Fix machine_check_poll() tests for which
 errors to log
Message-ID: <20190311204217.GA1810@agluck-desk>
References: <20190311185118.32667-1-tony.luck@intel.com>
 <SN6PR12MB26399CBAEFB6C500D456255DF8480@SN6PR12MB2639.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SN6PR12MB26399CBAEFB6C500D456255DF8480@SN6PR12MB2639.namprd12.prod.outlook.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 11, 2019 at 08:25:53PM +0000, Ghannam, Yazen wrote:
> > +		if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
> > +			goto log_it;
> > +
> 
> Can you please include a vendor check with this? MCi_STATUS[56] is
> not defined the same way on AMD systems.

Original code also looked at MCi_STATUS[56] without a vendor
check:

> > -               (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))

Was this OK because you don't set mca_cfg.ser?

If so, my new code will also skip out before getting to this test. But
should probably have a better comment. Something like:


		/*
		 * Newer Intel systems that support software error
		 * recovery need to make some extra checks. Other
		 * CPUs should skip over uncorrected errors, but log
		 * everything else
		 */
		if (!mca_cfg.ser) {
			if (m.status & MCI_STATUS_UC)
				continue;
			goto log_it;
		}

-Tony