Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Kernel Team <Kernel-team@fb.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "acme@redhat.com" <acme@redhat.com>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "sdf@fomichev.me" <sdf@fomichev.me>
Subject: Re: [PATCH v8 perf,bpf 10/15] perf-top: add option --no-bpf-event
Thread-Topic: [PATCH v8 perf,bpf 10/15] perf-top: add option --no-bpf-event
Thread-Index: AQHU2EShDF9NwauXz0Ol5cObQ7QoIqYG7EmA
Date:   Mon, 11 Mar 2019 21:07:20 +0000
Message-ID: <B1C5BA9A-20FB-46BA-A4D8-759CBA1C9ABD@fb.com>
References: <20190311195555.889995-1-songliubraving@fb.com>
 <20190311195555.889995-11-songliubraving@fb.com>
In-Reply-To: <20190311195555.889995-11-songliubraving@fb.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B77048A9FEF3E9439EDBA741DF544601@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a296df23-440a-4797-bfe8-08d6a6658cb7
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2019 21:07:20.0332
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1888
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-11_16:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 11, 2019, at 12:55 PM, Song Liu <songliubraving@fb.com> wrote:
>=20
> bpf events should be tracked by default for perf-top. This patch makes it
> on by default, and adds option to disable bpf events.
>=20
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> tools/perf/builtin-top.c | 3 +++
> tools/perf/util/top.h    | 1 +
> 2 files changed, 4 insertions(+)
>=20
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 27d8d42e0a4d..ccdf5689452f 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1492,6 +1492,7 @@ int cmd_top(int argc, const char **argv)
> 		    "Display raw encoding of assembly instructions (default)"),
> 	OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
> 		    "Enable kernel symbol demangling"),
> +	OPT_BOOLEAN(0, "no-bpf-event", &top.no_bpf_event, "do not record bpf ev=
ents"),
> 	OPT_STRING(0, "objdump", &top.annotation_opts.objdump_path, "path",
> 		    "objdump binary to use for disassembly and annotations"),
> 	OPT_STRING('M', "disassembler-style", &top.annotation_opts.disassembler_=
style, "disassembler style",
> @@ -1651,6 +1652,8 @@ int cmd_top(int argc, const char **argv)
> 		signal(SIGWINCH, winch_sig);
> 	}
>=20
> +	top.record_opts.bpf_event =3D !top.no_bpf_event;
> +
> 	status =3D __cmd_top(&top);
>=20
> out_delete_evlist:
> diff --git a/tools/perf/util/top.h b/tools/perf/util/top.h
> index 19f95eaf75c8..862a37bd27ea 100644
> --- a/tools/perf/util/top.h
> +++ b/tools/perf/util/top.h
> @@ -32,6 +32,7 @@ struct perf_top {
> 	bool		   use_tui, use_stdio;
> 	bool		   vmlinux_warned;
> 	bool		   dump_symtab;
> +	bool		   no_bpf_event;
> 	struct hist_entry  *sym_filter_entry;
> 	struct perf_evsel  *sym_evsel;
> 	struct perf_session *session;
> --=20
> 2.17.1
>=20

Hi Arnaldo,=20

Currently, we have bpf-event default OFF for perf-record, with option to=20
turn it ON; while bpf-event is default ON for perf-top, with option to=20
turn if OFF. I think this is a little confusing.=20

How about we set them both to default ON, and add option to turn it OFF?
I think we still have time to make the change.=20

Thanks,
Song