Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190304103846.2060-1-narmstrong@baylibre.com>
 <20190304103846.2060-9-narmstrong@baylibre.com> <1551924176.2210.104.camel@mhfsdcap03>
 <6eaff413-d2c7-125a-f165-e4226c7a153e@baylibre.com>
In-Reply-To: <6eaff413-d2c7-125a-f165-e4226c7a153e@baylibre.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Mon, 11 Mar 2019 22:19:00 +0100
Message-ID: <CAFBinCAUMNBeTABNeyOiYu9Gu8zWWmG3dBNJwFpop3QNp6ZG0g@mail.gmail.com>
Subject: Re: [PATCH v2 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     Chunfeng Yun <chunfeng.yun@mediatek.com>, balbi@kernel.org,
        gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com,
        linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 7, 2019 at 10:46 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
[...]
> >> +    /* Setup role switcher */
> >> +    priv->switch_desc.usb2_port = dwc3_meson_g12_find_child(dev,
> >> +                                                            "snps,dwc3");
> >> +    priv->switch_desc.udc = dwc3_meson_g12_find_child(dev, "snps,dwc2");
> >> +    priv->switch_desc.allow_userspace_control = true;
> >> +    priv->switch_desc.set = dwc3_meson_g12a_role_set;
> >> +    priv->switch_desc.get = dwc3_meson_g12a_role_get;
> > to me, use a local variable for switch_desc
>
> I'm never fan of changing a local global variable for a driver instance,
> is it strictly required ?
usb_role_switch_register (which is called a few lines below this)
copies all data from "struct usb_role_switch_desc" to a newly
allocated "struct usb_role_switch"
in other words: you could make it a stack-variable

personally I have no preference so I leave the decision up to you


Regards
Martin