Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
To:     "Luck, Tony" <tony.luck@intel.com>
CC:     Borislav Petkov <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ashok Raj <ashok.raj@intel.com>
Subject: RE: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors
 to log
Thread-Topic: [PATCH] x86, mce: Fix machine_check_poll() tests for which
 errors to log
Thread-Index: AQHU2DtsQDXo+RWhv0y/sb6komHrxqYG4DzQgAAFIYCAABe+UA==
Date:   Mon, 11 Mar 2019 22:10:29 +0000
Message-ID: <SN6PR12MB2639C9CC6B5BA0A1F1FE771DF8480@SN6PR12MB2639.namprd12.prod.outlook.com>
References: <20190311185118.32667-1-tony.luck@intel.com>
 <SN6PR12MB26399CBAEFB6C500D456255DF8480@SN6PR12MB2639.namprd12.prod.outlook.com>
 <20190311204217.GA1810@agluck-desk>
In-Reply-To: <20190311204217.GA1810@agluck-desk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 86ed4bca-a114-4951-9cdd-08d6a66e5f97
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2019 22:10:29.8077
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2814
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Luck, Tony <tony.luck@intel.com>
> Sent: Monday, March 11, 2019 3:42 PM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: Borislav Petkov <bp@alien8.de>; x86@kernel.org; linux-kernel@vger.ker=
nel.org; Ashok Raj <ashok.raj@intel.com>
> Subject: Re: [PATCH] x86, mce: Fix machine_check_poll() tests for which e=
rrors to log
>=20
> On Mon, Mar 11, 2019 at 08:25:53PM +0000, Ghannam, Yazen wrote:
> > > +		if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
> > > +			goto log_it;
> > > +
> >
> > Can you please include a vendor check with this? MCi_STATUS[56] is
> > not defined the same way on AMD systems.
>=20
> Original code also looked at MCi_STATUS[56] without a vendor
> check:
>=20
> > > -               (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_=
UC)))
>=20
> Was this OK because you don't set mca_cfg.ser?
>=20
> If so, my new code will also skip out before getting to this test. But
> should probably have a better comment. Something like:
>=20
>=20
> 		/*
> 		 * Newer Intel systems that support software error
> 		 * recovery need to make some extra checks. Other
> 		 * CPUs should skip over uncorrected errors, but log
> 		 * everything else
> 		 */
> 		if (!mca_cfg.ser) {
> 			if (m.status & MCI_STATUS_UC)
> 				continue;
> 			goto log_it;
> 		}
>=20

Yes, you're right. Thanks for pointing that out.

-Yazen