Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1511053imc; Mon, 11 Mar 2019 15:49:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBgtJgJ1CBuvAIU6HMYFjwp/csxGYu4khzagZbFQSRd8AKi6tbBc+hAlwg0rzuecPArzEO X-Received: by 2002:a63:c60c:: with SMTP id w12mr2542729pgg.446.1552344584427; Mon, 11 Mar 2019 15:49:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552344584; cv=none; d=google.com; s=arc-20160816; b=Qmeqo+HpDKg2HLHbricPHmqGyhK7IdOpxWvKxlCM5HcFGfV7Td3PyrSOpVfKccq1pA ur4Bu3KESw0TBy9VrlXzNXyl+lDcqb7ziDLSFdnAyIwwxgQLythl3itir7dxG54htp7C tYg03TKYfWHiZzCmLih9EOpwMJKOCMmVp2Xj4bXQTqhEwr9VHma2OGxeU5L4zUWjaNDR 8aRAYep47/iMW3gu4DAFPsVtw/qkG6UxEG9zQL8nmR66haD2xahQ71tzZxjNWwPeb+gn s5mwtqZdimTV/fTrY7sH35hxNBVPRPjEEqf4DZq+REu3+AULiStNYX3KuxYJXOu/GEPo fJvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=i9yEOOBa0P68mF94/bF8UwhfHKQL7Y0ylx6HyIzzamw=; b=QiErsUSBG+Ogzgz5Tkji99rRH3rsPwKOLSy773xjqpVzwmtQTx7bufhwc85Pc/opLI z12cr5VjrMBM40deEScSrTOjbvDMhAExN0aIQ3Ku48X6a6wDaNaaU+F7A6hgypvQPKQ8 gjS3XDk23KXakzGOLCpCOKPDKLzBrkCcs7+WcPchV473fdcw27Mn3PPdUDp6vOSSPBKw tDT3GcBeDJ5SNbxCcsbwzUqn7VqbhT1rdBqGt4R0JpQ0S48d65Za8k9Sg4rf3SVS05Je FLH36vSGsVGOcgGvbzpCa0MXLIoEWm0WZOqg8FdA1uERkg/J12lLVvAEGn+IFRuRz6XR apMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h8si5905233pgr.492.2019.03.11.15.49.28; Mon, 11 Mar 2019 15:49:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbfCKWsm (ORCPT + 99 others); Mon, 11 Mar 2019 18:48:42 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33984 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726744AbfCKWsX (ORCPT ); Mon, 11 Mar 2019 18:48:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8C24A78; Mon, 11 Mar 2019 15:48:22 -0700 (PDT) Received: from e113632-lin.cambridge.arm.com (e113632-lin.cambridge.arm.com [10.1.194.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F2DFF3F59C; Mon, 11 Mar 2019 15:48:21 -0700 (PDT) From: Valentin Schneider To: linux-kernel@vger.kernel.org Cc: "David S. Miller" , sparclinux@vger.kernel.org Subject: [PATCH 12/14] sparc64: rtrap: Remove unneeded need_resched() loop Date: Mon, 11 Mar 2019 22:47:50 +0000 Message-Id: <20190311224752.8337-13-valentin.schneider@arm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190311224752.8337-1-valentin.schneider@arm.com> References: <20190311224752.8337-1-valentin.schneider@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. We seem to be looping back somewhere much higher than the usual preempt/need_resched checks, but AFAICT we would just branch to 'rtrap_no_irq_enable' and then back to 'to_kernel', which is a need_resched() loop with a few extra steps. Signed-off-by: Valentin Schneider Cc: "David S. Miller" Cc: sparclinux@vger.kernel.org --- arch/sparc/kernel/rtrap_64.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/sparc/kernel/rtrap_64.S b/arch/sparc/kernel/rtrap_64.S index 29aa34f11720..57fb75686957 100644 --- a/arch/sparc/kernel/rtrap_64.S +++ b/arch/sparc/kernel/rtrap_64.S @@ -322,7 +322,6 @@ to_kernel: nop call preempt_schedule_irq nop - ba,pt %xcc, rtrap #endif kern_fpucheck: ldub [%g6 + TI_FPDEPTH], %l5 brz,pt %l5, rt_continue -- 2.20.1