Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1526931imc; Mon, 11 Mar 2019 16:17:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzX8xFwdaQRCpVI4rf3eM4Q9Y7GKG9/J2e9RBDo88q0rjsWxz0yHxyo8v7riZ9ruLQf2zzI X-Received: by 2002:a17:902:42:: with SMTP id 60mr31064994pla.132.1552346250382; Mon, 11 Mar 2019 16:17:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552346250; cv=none; d=google.com; s=arc-20160816; b=z3Vk+ieJMt67+OLzyldatgxj5827uLiXepksqqUoH37b6d5KHaTUeFOdCUGCk/sG74 wGr52qH38eqDLRvhTRPgCbhCipj/WVQdEwc2wf8CrOYTjQfSnnqhRvsX7C19jB/q59vZ Q014V9KfchK2JXe3KWBeYsmfi0t0RLUjQbsv4ytjTXydaMUz2GA8b4oTWnwGr7lH7AGy 2ofJPIFiNnISDjsUWRo6ZwCbY94IkWZ122BulZkQkf517KhNHRqul8aFKiXYDR1chbwz DjelKIhj5KcB38RgNvTd7d9oWBoTeapuyS6RSXVTKQ8nj4U2IkK81L4ifrbZl99A1p1T hcjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LnjANkZ+uvjp0aJvECm1ram1U1TbrSbsqAjAqxg9evw=; b=aqccBM8aofM4A9GO+bHA8aUmdOU7tJPIr7erDMpsofeZCY7hvBxDMJrShPl1pHD9VB s2R1qiZ56yoPER91451DpyS4h/D+SdRObcj1pJ7ZW+5P8c6YF3pEepuOnrnz3KkYYGPM 7LEsB3Be8r5RCXDOsBN8F/x1T4GWT4kvKBNIktNKJ9Ugj4cNaOrSMfpVyMMYQ5xkIQGZ bUrAHG6KVKERkQPKq3FRU6FIkQV9Kvae/NtYsST4lALdZYOOWldmknyHpufZbscz/mz1 HPRS3YCWhQccQBFpc2RjRtqsd0L+TqzOo42H+1D8BExz7bfWq+WaRdDbSzW8Ioj1U18z UOoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PLWiwHZ4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i21si5878353pgh.123.2019.03.11.16.17.14; Mon, 11 Mar 2019 16:17:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PLWiwHZ4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbfCKXQa (ORCPT + 99 others); Mon, 11 Mar 2019 19:16:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:34976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbfCKXQ3 (ORCPT ); Mon, 11 Mar 2019 19:16:29 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 706BD2148D; Mon, 11 Mar 2019 23:16:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552346188; bh=LnjANkZ+uvjp0aJvECm1ram1U1TbrSbsqAjAqxg9evw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PLWiwHZ4vGL96dh+px6EvERsIO+MW6KrAhSZiOgKP6B7X0I+FNneHLlOrz1NOTwjO 2lZ+ug3M4C8+eGp6cdAZgCmChN2YonKwJj2cCt/vi2lpLlwltp//rrsLBFSnKfkvlH b5HaKGrgU965h4aaUwZuY70CPCuhrcptd+vJzwPo= Date: Mon, 11 Mar 2019 19:16:27 -0400 From: Sasha Levin To: Dmitry Kasatkin Cc: Al Viro , yuehaibing , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "keescook@chromium.org" , "stable@vger.kernel.org" , "gregkh@google.com" Subject: Re: [PATCH -next] exec: Fix mem leak in kernel_read_file Message-ID: <20190311231627.GI158926@sasha-vm> References: <20190219021038.11340-1-yuehaibing@huawei.com> <20190219022512.GW2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 11, 2019 at 04:59:14PM +0000, Dmitry Kasatkin wrote: > >From: Al Viro on behalf of Al Viro >Sent: Tuesday, February 19, 2019 4:25 AM >To: yuehaibing >Cc: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; Dmitry Kasatkin; keescook@chromium.org >Subject: Re: [PATCH -next] exec: Fix mem leak in kernel_read_file >? >On Tue, Feb 19, 2019 at 10:10:38AM +0800, YueHaibing wrote: >> syzkaller report this: >> BUG: memory leak >> unreferenced object 0xffffc9000488d000 (size 9195520): >>?? comm "syz-executor.0", pid 2752, jiffies 4294787496 (age 18.757s) >>?? hex dump (first 32 bytes): >>???? ff ff ff ff ff ff ff ff a8 00 00 00 01 00 00 00? ................ >>???? 02 00 00 00 00 00 00 00 80 a1 7a c1 ff ff ff ff? ..........z..... >>?? backtrace: >>???? [<000000000863775c>] __vmalloc_node mm/vmalloc.c:1795 [inline] >>???? [<000000000863775c>] __vmalloc_node_flags mm/vmalloc.c:1809 [inline] >>???? [<000000000863775c>] vmalloc+0x8c/0xb0 mm/vmalloc.c:1831 >>???? [<000000003f668111>] kernel_read_file+0x58f/0x7d0 fs/exec.c:924 >>???? [<000000002385813f>] kernel_read_file_from_fd+0x49/0x80 fs/exec.c:993 >>???? [<0000000011953ff1>] __do_sys_finit_module+0x13b/0x2a0 kernel/module.c:3895 >>???? [<000000006f58491f>] do_syscall_64+0x147/0x600 arch/x86/entry/common.c:290 >>???? [<00000000ee78baf4>] entry_SYSCALL_64_after_hwframe+0x49/0xbe >>???? [<00000000241f889b>] 0xffffffffffffffff >> >> It should goto 'out_free' lable to free allocated buf while kernel_read >> fails. > >Applied. > > >This must be applied to stables as well... It's already in all relevant stable trees... -- Thanks, Sasha