Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 12 Mar 2019 12:16:54 +1100
From:   "Tobin C. Harding" <me@tobin.cc>
To:     Roman Gushchin <guro@fb.com>
Cc:     "Tobin C. Harding" <tobin@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Christopher Lameter <cl@linux.com>,
        Pekka Enberg <penberg@cs.helsinki.fi>,
        Matthew Wilcox <willy@infradead.org>,
        Tycho Andersen <tycho@tycho.ws>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 01/15] slub: Create sysfs field /sys/slab/<cache>/ops
Message-ID: <20190312011654.GD9362@eros.localdomain>
References: <20190308041426.16654-1-tobin@kernel.org>
 <20190308041426.16654-2-tobin@kernel.org>
 <20190311212316.GA4581@tower.DHCP.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190311212316.GA4581@tower.DHCP.thefacebook.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 11, 2019 at 09:23:27PM +0000, Roman Gushchin wrote:
> On Fri, Mar 08, 2019 at 03:14:12PM +1100, Tobin C. Harding wrote:
> > Create an ops field in /sys/slab/*/ops to contain all the callback
> > operations defined for a slab cache. This will be used to display
> > the additional callbacks that will be defined soon to enable movable
> > objects.
> > 
> > Display the existing ctor callback in the ops fields contents.
> > 
> > Co-developed-by: Christoph Lameter <cl@linux.com>
> > Signed-off-by: Tobin C. Harding <tobin@kernel.org>
> 
> Hi Tobin!
> 
> > ---
> >  mm/slub.c | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/mm/slub.c b/mm/slub.c
> > index dc777761b6b7..69164aa7cbbf 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -5009,13 +5009,18 @@ static ssize_t cpu_partial_store(struct kmem_cache *s, const char *buf,
> >  }
> >  SLAB_ATTR(cpu_partial);
> >  
> > -static ssize_t ctor_show(struct kmem_cache *s, char *buf)
> > +static ssize_t ops_show(struct kmem_cache *s, char *buf)
> >  {
> > +	int x = 0;
> > +
> >  	if (!s->ctor)
> >  		return 0;
>         ^^^^^^^^^^^^^^^^^
> You can drop this part, can't you?
> 
> Also, it's not clear (without looking into following patches) why do you
> make this refactoring. So, please, add a note, or move this change into
> the patch 3.

No worries, thanks for looking at this.  Will amend the commit message
and drop the constructor check.

thanks,
Tobin