Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1784151imc; Tue, 12 Mar 2019 00:02:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqx+ejJB2j4YJNeL7zlFt1Ssq6Qk9oVWlFHH9gYhpChBfYHbpBKbN+z+lFcVLAUJtAOGyaBh X-Received: by 2002:a17:902:a981:: with SMTP id bh1mr38719325plb.88.1552374157332; Tue, 12 Mar 2019 00:02:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552374157; cv=none; d=google.com; s=arc-20160816; b=vX5khtG81U7jwlaIvkqSp2nxO013MYiauFCKpO090vqRWXqvxK8kFDlZPb63Bbo0Ny gGzTgjc8XSsCWqMihkQO2JZdGMH9tcKTXax+yG+Diax9iPxcnuGhFyF6j/sTyWHikQHx SPL60TIPhhebul1CXvYLBfY0whvhTROPNlo4IbB8fC47P0CiFPMqF0wadI7NO0tQjn/J 55jfbbYm3VoBY79hre9WgVTAhn3wllSrZfhEo+E0BqxQ2k+AnKeYdY9AMqo3cMc9eSzn 8w72DMbhjaoeAGFdS9r6Zo68GySflsNUtwBBwb4a1XR1JSmvgD87j+ZsYieNJBJRYtVI KQLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=cmo5xzZC20V+EjO6dRXRm3xA7jb6LDV8i6W1/5mEZhY=; b=bi0K/NaXjUAGE0BFZoew7hzdCgFwc748D4dYG2ZshLjvDV0TzHFhUzk5m7yNJeXBdw NrU9YUcj2sgoqEzc9TcYPWSpNJCYDgWTUuZJd5CDe19JvEjFG32aWvR9PC6CMcYu+Yj7 jXHoNl8pudQEkCYuGxVzYTmjzojm8HELqI2ZJ15ymNOdMn3dFI5x2mEsUYAPdthQ8JGy 1vjNpIpLbXx8Y7kkFnpiqD9Vwmn3/sJrhmIEqc/oi765TzXCtoc6zuwp6k7jCZScyMGQ t3UgOMppWKvUcWf/j3evQLix4JQAQ8++K58oNZZp5XxqV6j9IQT2zflnYRUV4S60W9bA dvkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si7063163pga.350.2019.03.12.00.02.21; Tue, 12 Mar 2019 00:02:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbfCLHBu (ORCPT + 99 others); Tue, 12 Mar 2019 03:01:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51496 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726633AbfCLHBu (ORCPT ); Tue, 12 Mar 2019 03:01:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58D4E30832D8; Tue, 12 Mar 2019 07:01:50 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-148.rdu2.redhat.com [10.10.121.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F13D5DA62; Tue, 12 Mar 2019 07:01:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <22096.1551878195@warthog.procyon.org.uk> <10106.1551892803@warthog.procyon.org.uk> <17155.1552056554@warthog.procyon.org.uk> <2827.1552315718@warthog.procyon.org.uk> To: Christian Kujau Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, Anna Schumaker , Steve Dickson Subject: Re: FS-Cache: Duplicate cookie detected MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8938.1552374108.1@warthog.procyon.org.uk> Date: Tue, 12 Mar 2019 07:01:48 +0000 Message-ID: <8939.1552374108@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 12 Mar 2019 07:01:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christian Kujau wrote: > My /usr/local/src mount was mounted with vers=4.2 (default), while > nfstest_cache was mounting its test-mount with vers=4.1! Apart from the > different rsize/wsize values, the version number stood out. And indeed, > when I mount my regular NFS mount /usr/local/src with vers=4.1, the > "duplicate cookie" is no longer printed. Yeah - NFS superblocks are differentiated by a whole host of parameters, including protocol version number, and caches aren't shared between superblocks because this introduces a tricky coherency problem. The issue is that NFS superblocks to the same place do not currently manage coherency (inode attributes, data) between themselves, except via the server. However, if "fsc" isn't given on the mount commandline, the superblock probably shouldn't get a server-level cookie if we can avoid it. David