Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263435AbUCTPDK (ORCPT ); Sat, 20 Mar 2004 10:03:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263437AbUCTPDK (ORCPT ); Sat, 20 Mar 2004 10:03:10 -0500 Received: from mail-ext.curl.com ([66.228.88.132]:36616 "HELO mail-ext.curl.com") by vger.kernel.org with SMTP id S263435AbUCTPDH convert rfc822-to-8bit (ORCPT ); Sat, 20 Mar 2004 10:03:07 -0500 From: "Patrick J. LoPresti" Message-ID: To: =?iso-8859-1?q?J=F6rn?= Engel Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] cowlinks v2 References: <20040320083411.GA25934@wohnheim.fh-wedel.de> Date: 20 Mar 2004 10:03:05 -0500 In-Reply-To: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 19 Neat stuff! But... J?rn Engel writes: > + * Files with the S_COWLINK flag set cannot be written to, if more > + * than one hard link to them exists. Ultimately, this function > + * should copy the inode, assign the copy to the dentry and lower use > + * count of the old inode - one day. What happens if the disk fills while you are making the copy? Will open(2) on an *existing file* then return ENOSPC? I do not think you can implement this without changing the interface to open(2). Which means applications have to be made aware of it anyway. Which means you might as well leave your implementation as-is and let userspace worry about creating the copy (and dealing with the resulting errors). - Pat - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/