Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp1850209imc; Tue, 12 Mar 2019 01:49:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqxaO7GwB6TqRJtq5Rg83Engm7gdm90qgHzic8nD5TxMobZ0hwd8jyBV3RLuolUhnet4pHVH X-Received: by 2002:a63:c60c:: with SMTP id w12mr4475452pgg.446.1552380590532; Tue, 12 Mar 2019 01:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552380590; cv=none; d=google.com; s=arc-20160816; b=w0ywIkHElhjt345jWCe5rRYq1/UMzHGm3Mua4Fe7EzM98fyJVYSmXl3rqz4S0X7kq6 wGBb/huKxNTrqB9bIoJ+zc9ZDAY5cXKxqYrGivZJ0THOt5n7/GfLsURoTGLoE5IswYUM JnqTBj98pNv6uycY7k6o9uoO3E/StjiKMYOmw7fmL92Jltj8hJEzRz2aaRc2QYT7SrHp hfg/CLJSLzCaLZuKTfIkdATMQSFiOZcAPPZSRxHRnOq38iYS4pRnDZf9LBncm9zGyPVd FyPhg1bT9LglacC0nlt3s1zw9kiQNH6FXY5IaQ5W5Ev0weA8l+qgdmHGpugLRJPn/Knt /MKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=qWRjILUJ5jjZY9FFH+5ZJYFjW1Di+opuV2JZeSRLmxM=; b=D9fXscGnH2KsAjKCag5mTwG1Rt5lNTjXZEh+3fEqoYHQImrsOmAAHa24fOIYrM8Ez3 dBzqV7I1G/wFsMh6/EPvMyPLiY504aNOSimsDDvu8Aqan1s4uQoFcgOxNdt8Jc8Kclx9 gB9PZJwwbksigQm+9c+7LZGx3BaV4V+1fqXdZqXQp0u11r+itwyWuh9ugrxVjAFwhpm2 3xGvp7JCoIZHBQlXY/d8sFilohHiEZfMP3g42pZxCed8o5NOsnGzATyX3Ztqti7TqfTI lcrHShm1pMBFQDM7ONSEiy5Y+/6fCZ4dYbX/EBELug+BXIIOYNISbNZUArAvX6IvjF9l 6LNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="NORy5/8b"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24si7214955pgj.502.2019.03.12.01.49.34; Tue, 12 Mar 2019 01:49:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="NORy5/8b"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727469AbfCLIqk (ORCPT + 99 others); Tue, 12 Mar 2019 04:46:40 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:37380 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726560AbfCLIqk (ORCPT ); Tue, 12 Mar 2019 04:46:40 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id x2C8j6Zd004092; Tue, 12 Mar 2019 17:45:18 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com x2C8j6Zd004092 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1552380318; bh=qWRjILUJ5jjZY9FFH+5ZJYFjW1Di+opuV2JZeSRLmxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NORy5/8bdn8Lkj/xBxzJVLbdu4wKQmDJUa7pWwu9BQgl5fN6jzQLlUeEsV4rGrTnv nqDHbOH/aXTOuFsl1GePMvdWrJeRoHTEAlUrIlE1wC5BE87hVSH61Nz8krg0rf1Y+R WxNnAjLL5G7REQ/OpZYjmIcmgEQ8pr2FVTi50rMCQbdDbxuJ6nRJZCYVqgnrTkgsX+ CRMJoAt0XC0BTImMtYETULmyaa2f8jrGiRrTINzyj6dp9nNRrGSr99ummQCkEhiUbF 6CJ0jbOTovxDo2mmcPo43S6IrzA6JJaMvWxzVhVKDCqnYRcRD0ks2C1dWhcA7vYtyA o2fROoHmL4rSQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Cc: Boris Brezillon , Masahiro Yamada , Brian Norris , linux-kernel@vger.kernel.org, Marek Vasut , Richard Weinberger , David Woodhouse Subject: [PATCH v3 3/9] mtd: rawnand: denali: remove unneeded casts in denali_{read,write}_pio Date: Tue, 12 Mar 2019 17:44:44 +0900 Message-Id: <1552380290-19951-4-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> References: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since (u32 *) can accept an opaque pointer, the explicit casting from (void *) to (u32 *) is redundant. Change the function argument type to remove the casts. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index ebeedbd..d2040b7 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -478,11 +478,10 @@ static void denali_setup_dma32(struct denali_nand_info *denali, denali->host_write(denali, mode | 0x14000, 0x2400); } -static int denali_pio_read(struct denali_nand_info *denali, void *buf, +static int denali_pio_read(struct denali_nand_info *denali, u32 *buf, size_t size, int page) { u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page; - uint32_t *buf32 = (uint32_t *)buf; uint32_t irq_status, ecc_err_mask; int i; @@ -494,7 +493,7 @@ static int denali_pio_read(struct denali_nand_info *denali, void *buf, denali_reset_irq(denali); for (i = 0; i < size / 4; i++) - *buf32++ = denali->host_read(denali, addr); + buf[i] = denali->host_read(denali, addr); irq_status = denali_wait_for_irq(denali, INTR__PAGE_XFER_INC); if (!(irq_status & INTR__PAGE_XFER_INC)) @@ -506,18 +505,17 @@ static int denali_pio_read(struct denali_nand_info *denali, void *buf, return irq_status & ecc_err_mask ? -EBADMSG : 0; } -static int denali_pio_write(struct denali_nand_info *denali, - const void *buf, size_t size, int page) +static int denali_pio_write(struct denali_nand_info *denali, const u32 *buf, + size_t size, int page) { u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page; - const uint32_t *buf32 = (uint32_t *)buf; uint32_t irq_status; int i; denali_reset_irq(denali); for (i = 0; i < size / 4; i++) - denali->host_write(denali, addr, *buf32++); + denali->host_write(denali, addr, buf[i]); irq_status = denali_wait_for_irq(denali, INTR__PROGRAM_COMP | INTR__PROGRAM_FAIL); -- 2.7.4