Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ata: pata_oldpiix: Add missing device ID for
 INTEL_82371AB
To:     LABBE Corentin <clabbe@baylibre.com>
Cc:     axboe@kernel.dk, b.zolnierkie@samsung.com,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1544449564-16557-1-git-send-email-clabbe@baylibre.com>
 <9aab3632-4647-cb66-f720-8f6742bc9b4e@cogentembedded.com>
 <20190312104102.GA28302@Red>
From:   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Organization: Cogent Embedded
Message-ID: <1387821f-20d2-672f-5a7d-f7c2c4334dee@cogentembedded.com>
Date:   Tue, 12 Mar 2019 13:44:20 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20190312104102.GA28302@Red>
Content-Type: text/plain; charset=utf-8
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/12/2019 01:41 PM, LABBE Corentin wrote:

>>> When playing with a virtual SPARC machine with qemu, I found that the
>>> IDE emulated device was not probing with the ata/pata_oldpiix driver.
>>
>>    Correctly, it should probe with ata_piix,
>>
>>> But with the old ide/piix, it was probed.> 
>>> This is due to this PCI devid was not migrated from the old ide/piix.
>>
>>    It wasn't on purpose -- the IDE driver supports the original PIIX
>> incorrectly.
>>
> 
> Hello
> 
> What about removing this old driver totally if it dont work ?

   It supports the later Intrel controllers OK, just the original PIIX support
is buggy.

> Regards

MBR, Sergei