Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 12 Mar 2019 14:38:08 +0100
From:   LABBE Corentin <clabbe@baylibre.com>
To:     Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc:     Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        axboe@kernel.dk, b.zolnierkie@samsung.com,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_oldpiix: Add missing device ID for
 INTEL_82371AB
Message-ID: <20190312133808.GA9336@Red>
References: <1544449564-16557-1-git-send-email-clabbe@baylibre.com>
 <9aab3632-4647-cb66-f720-8f6742bc9b4e@cogentembedded.com>
 <20190312104102.GA28302@Red>
 <20190312120623.46ca7286@alans-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190312120623.46ca7286@alans-desktop>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 12, 2019 at 12:06:23PM +0000, Alan Cox wrote:
> On Tue, 12 Mar 2019 11:41:02 +0100
> LABBE Corentin <clabbe@baylibre.com> wrote:
> 
> > On Mon, Dec 10, 2018 at 05:52:35PM +0300, Sergei Shtylyov wrote:
> > > Hello!
> > > 
> > > On 12/10/2018 04:46 PM, Corentin Labbe wrote:
> > >   
> > > > When playing with a virtual SPARC machine with qemu, I found that the
> > > > IDE emulated device was not probing with the ata/pata_oldpiix driver.  
> > > 
> > >    Correctly, it should probe with ata_piix,
> > >   
> > > > But with the old ide/piix, it was probed.> 
> > > > This is due to this PCI devid was not migrated from the old ide/piix.  
> > > 
> > >    It wasn't on purpose -- the IDE driver supports the original PIIX
> > > incorrectly.
> > >   
> > 
> > Hello
> > 
> > What about removing this old driver totally if it dont work ?
> 
> If the virtual Sparc emulator is using it does that also mean actual
> Sparc hardware has it. In which case presumably it needs fixing, or at
> least moving to the generic driver assuming the firmware sets it up ?
> 

The qemu works perfectly with the new Linux driver.