Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190312132852.20115-1-brgl@bgdev.pl> <c86234af-a83a-712a-8dc8-0ec2a5dad103@oracle.com>
In-Reply-To: <c86234af-a83a-712a-8dc8-0ec2a5dad103@oracle.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Tue, 12 Mar 2019 15:03:52 +0100
Message-ID: <CAMpxmJVeeMRPaXMKp29mE08pKFU4RRMetY=9-pWmazLg3DMLbg@mail.gmail.com>
Subject: Re: [PATCH] mm: remove unused variable
To:     Khalid Aziz <khalid.aziz@oracle.com>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Andrew Morton <akpm@linux-foundation.org>,
        Anthony Yznaga <anthony.yznaga@oracle.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
        =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

wt., 12 mar 2019 o 14:59 Khalid Aziz <khalid.aziz@oracle.com> napisa=C5=82(=
a):
>
> On 3/12/19 7:28 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > The mm variable is set but unused. Remove it.
>
> It is used. Look further down for calls to set_pte_at().
>
> --
> Khalid
>
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> >  mm/mprotect.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/mm/mprotect.c b/mm/mprotect.c
> > index 028c724dcb1a..130dac3ad04f 100644
> > --- a/mm/mprotect.c
> > +++ b/mm/mprotect.c
> > @@ -39,7 +39,6 @@ static unsigned long change_pte_range(struct vm_area_=
struct *vma, pmd_t *pmd,
> >               unsigned long addr, unsigned long end, pgprot_t newprot,
> >               int dirty_accountable, int prot_numa)
> >  {
> > -     struct mm_struct *mm =3D vma->vm_mm;
> >       pte_t *pte, oldpte;
> >       spinlock_t *ptl;
> >       unsigned long pages =3D 0;
> >
>
>

Oops, I blindly assumed the compiler is right, sorry for that. GCC
complains it's unused when building usermode linux. I guess it's a
matter of how set_pte_at() is defined for ARCH=3Dum. I'll take a second
look.

Bart