Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp2176495imc; Tue, 12 Mar 2019 08:29:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzj3l7TEY5F43qa5OVJMG/432ZGgHkksMJtf8dJKnfOHgCuAkIBaML/xcZXsRy3bRwVIaIX X-Received: by 2002:a17:902:9306:: with SMTP id bc6mr39662288plb.59.1552404543797; Tue, 12 Mar 2019 08:29:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552404543; cv=none; d=google.com; s=arc-20160816; b=JelhnEy3MKZtGGAplU63zjcIvQ9CeHTFWWowsMmR6YObQ5FFlMKU+txTmmcD56ny1s B8D9buXxCyEYWuClsjAgSL7pwKqYCLDXHKibKM6V3FliWk0EUERij99Wx1wUaLBjfTLO XLYNwjabO4g52XZEY+3JKvhXNhF+qU4XI9bcSFAOq2gMBmq2y7myU5GBrKmHNopejEET A1H+qCrFDatqMfEO2/MJvihKs+VQIqoY2mCV6bRCSFr6Gfg3w3mWbgonnLkQN4Yfz0E/ GVTLiyFSDJ4l22BrBESd5gywz2HRnAnGJLqnqV+jHzmurA2CCNbAbCMapwhtE2bMGh7P 1s3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ODldI1C3mxz+vy99PjB8RPMPSBYb65r6oyz5C0XKTeA=; b=LKwt6MaLNbhdAVDowP48Haau4ETXh/sVblQzwS/RR9sLyp0yIdxuJRiYlhsKl4IXIK EhMRH85wPFx3ZCGM01Bwy5EzPkofOJk9Y31jxcGuj1NMiqu6hU26nmaYQX4gwL6Z0aXx oYqEWJ0DoatbOxipDzbdfW4KJ4a+XgFsM6d5BriaK1yCTzUzKS0KUS7VHdcC+YBArkOT nt4gjAFSeMF+o5Q/TrWbI9axyqKqTed9+tJSmMcDxEY9aAF3tlHYeprvqds7Yd1y8bYT zzhfIkqLt2Y0ZbrcuFUn7LQXcQup2CTubzuEZlZjTc7OJLvnL2YFuoebfBqHOBndewyA HPPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RxDwlbGQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14si7728396pgg.377.2019.03.12.08.28.47; Tue, 12 Mar 2019 08:29:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RxDwlbGQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbfCLP1K (ORCPT + 99 others); Tue, 12 Mar 2019 11:27:10 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35152 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726192AbfCLP1K (ORCPT ); Tue, 12 Mar 2019 11:27:10 -0400 Received: by mail-pg1-f195.google.com with SMTP id e17so2103955pgd.2; Tue, 12 Mar 2019 08:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ODldI1C3mxz+vy99PjB8RPMPSBYb65r6oyz5C0XKTeA=; b=RxDwlbGQAW3JTCLL1+jv+mN8bZwA8VfHgdf7CbkeBpwiVG+sFJjX191tO7dHFF3cii se8p3GqJJlfdIYNFS96VhSwCdrH7rLGLsN9CztXmdPA+VZzFBAciy0T8ABUveZNrMFj7 TiJYe6C9HKwezW5zqIOUm3hXR+1xcZPiFHFDI+rhNjCzTie1DWpU42AlQJoypURfaOUi /LYuTrYK6AVa0rARWpg/13flpCP5rAl0qK/9Evo8CyYY+xXZiuiPj0miLxhudp0zmXPx K1TB3jvM/46cffLa3OuzwhPxBKVlk2ry2VmYv4flgUNKTawH1cV2FbFWnOJIjfEj+OKQ CxPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ODldI1C3mxz+vy99PjB8RPMPSBYb65r6oyz5C0XKTeA=; b=i94PJFEtU/MhRevtTzYykXM2nMtafy72Z2Q4rM8klAkfZ6RSGLRnksmNbIZD77wWY6 eVB3AAN3KkB39djkmgpHKDSanZX385CkrkakCfZGH7V8vZ09WzhCRCigWqCq4rVwA7AR tRWTg3mAT61HXqlT9aglrgWFKaxsgzujL6jEsyFIbawPk+0nHudqgCGvBkLqouGuELTK cfQ5BXa6hdCx07kgQasJBzwWrm82wuNCyoxKeaunPJoXRwfv3ppippS3lXdRTkzEDDRQ puYny40/x9FQJ11y0xcdmBSFt5wWd6kJnohMUg2CTkDUAphCQHPStHORFqG/6Av58J8C q4Sg== X-Gm-Message-State: APjAAAUzk+7C6VIBs7wEopxAvUldQpCR2VuKzD4IjDD+KnRtHhY+Y7m3 AjCukkVcmLQ3tSNd2wZ4vOI= X-Received: by 2002:a17:902:6804:: with SMTP id h4mr40331528plk.115.1552404429059; Tue, 12 Mar 2019 08:27:09 -0700 (PDT) Received: from ast-mbp ([2620:10d:c090:180::4168]) by smtp.gmail.com with ESMTPSA id q78sm15818107pfa.138.2019.03.12.08.27.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 08:27:08 -0700 (PDT) Date: Tue, 12 Mar 2019 08:27:06 -0700 From: Alexei Starovoitov To: Qais Yousef Cc: Steven Rostedt , Ingo Molnar , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" Subject: Re: [RFC][PATCH] Export supported trace features in debugfs Message-ID: <20190312152703.dulqcnhkknklxihq@ast-mbp> References: <20190312110437.5977-1-qais.yousef@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190312110437.5977-1-qais.yousef@arm.com> User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 12, 2019 at 11:07:14AM +0000, Qais Yousef wrote: > eBPF tools like bcc-tools have hard time figuring out when features like > raw_tracepoint are supported in the kernel on which we are running. At > the moment a fragile mechanism of matching bpf_find_raw_tracepoint() > function in /proc/kallsyms is used to find out whether raw tracepoints > can be used or not. But when this function was renamed recently to > bpf_get_raw_tracepoint() the tool started to fail to use raw > tracepoints. > > To help in providing a more reliable way to detect features like > RAW_TRACEPOINT, add a new file in trace debugfs to export the supported > features. > > $cat /sys/kernel/debug/tracing/supported_features > RAW_TRACEPOINT > EXAMPLE_FEATURE_1 > EXAMPLE_FEATURE_2 > > Signed-off-by: Qais Yousef this type of attempts have been made in the past and we always rejected them. Please use 'bpftool' instead that detects numerous bpf related features including raw_tp. # bpftool feature probe|grep raw_tracepoint eBPF program_type raw_tracepoint is available