Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable
References: <20190301184816.784-1-mans@mansr.com>
        <20190301184816.784-3-mans@mansr.com>
        <CAHp75VfZUN0PVwveB9FM6QvyJicVE5WjCX3b5rfCGZOQs9hO8A@mail.gmail.com>
Date:   Tue, 12 Mar 2019 15:48:06 +0000
In-Reply-To: <CAHp75VfZUN0PVwveB9FM6QvyJicVE5WjCX3b5rfCGZOQs9hO8A@mail.gmail.com>
        (Andy Shevchenko's message of "Tue, 12 Mar 2019 17:45:24 +0200")
Message-ID: <yw1xo96g2ix5.fsf@mansr.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Andy Shevchenko <andy.shevchenko@gmail.com> writes:

> On Fri, Mar 1, 2019 at 9:14 PM Mans Rullgard <mans@mansr.com> wrote:
>>
>> The charlcd driver currently flashes the backlight once on init.
>> This may not be desirable.  Thus, add options for turning the
>> backlight off or on as well.
>>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>> ---
>>  drivers/auxdisplay/Kconfig   | 21 +++++++++++++++++++++
>>  drivers/auxdisplay/charlcd.c | 10 +++++++++-
>>  2 files changed, 30 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
>> index 7d3fe27d6868..c52c738e554a 100644
>> --- a/drivers/auxdisplay/Kconfig
>> +++ b/drivers/auxdisplay/Kconfig
>> @@ -445,6 +445,27 @@ config PANEL_BOOT_MESSAGE
>>           An empty message will only clear the display at driver init time. Any other
>>           printf()-formatted message is valid with newline and escape codes.
>>
>> +choice
>> +       prompt "Backlight initial state"
>> +       default CHARLCD_BL_FLASH
>
> LGTM, but I don't agree on this default. I would prefer either on or
> off, not flashing for sure.
> Though it seems the case before the patch...

The current code unconditionally flashes the light once.  I though it
best to keep that behaviour as default, even if it's not seen as ideal.

-- 
M?ns Rullg?rd