Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp2225142imc; Tue, 12 Mar 2019 09:22:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJ4e2XU8qCfzlCzOhsqsi/CQylwjX4t5RlEZ2sbBFoBlALdV88Dlz2SvHjZ/GsQksFWx+s X-Received: by 2002:a62:5e46:: with SMTP id s67mr39301957pfb.126.1552407734930; Tue, 12 Mar 2019 09:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552407734; cv=none; d=google.com; s=arc-20160816; b=qUdCpSEJXSU8V+jacqw9X5BrnKNHzC7XbcMC5/vliWHFrYGUiJXK2YPWJWCbOV60TR ZqJfw15YXU64z9iaMvJgRMPSpzvA53GNrZLzC9E2nqeh12rnY89QDxEwXLZiU8STrZqV FON2gQrmAuGQMqqjnfH/f7WFf3euu36GdyQk6rI5/Pq3P203KR/ZsZfXDPTR5AAcrj47 oredyfc8kh1unqco7pACKxMY3hKsBK+ZxCLF4DwSpztZ6eiu4Z7qdpssT/Up3+MaavGR MV/OXZ+dR9qboxbzKIP+YpKacUqBU02rCe3XB+/51I8aqhUthfi3cFAjSWTkGfIpIGFD yLzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=tawD2D2yhPxJ6jVXdtHNzTe8sO1hTye0ddBxemZiBK0=; b=Oh8Ug35Glh4ty4QpTT0orOK4kmzY03QbXynZXbhGo9JKeT6TlFfRXuMwKSFckrI+Kx m7rqYdipxTbOqIaSTRFUe2Gp8bAj9c/USBGKP0yYcdN6V+ghg0hxwk64ghkpaGDT8O25 xqUXlnSQrADEeobdPcuHz97OZdNLbcmlswMaZhVpT21cBoriSf4Q4gEQgNWCgZVF2ZDw 1SuIbXKcxPXlScO/DtJ54Hqbq2hYUyNcLpWbLGeMi577d32NgNqO+LAdZtjrZCqA6If9 lxVeZaFQSYAWq6tZjuyXh7Uw1gZfiQgQ/FynPPPmYJYqysctyq3PMQ/ZjZ+MvwdhLwVG AWgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Yqjdboxf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 186si8602114pfe.262.2019.03.12.09.21.58; Tue, 12 Mar 2019 09:22:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Yqjdboxf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbfCLQVh (ORCPT + 99 others); Tue, 12 Mar 2019 12:21:37 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:40313 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbfCLQVg (ORCPT ); Tue, 12 Mar 2019 12:21:36 -0400 Received: by mail-it1-f194.google.com with SMTP id l139so5413661ita.5 for ; Tue, 12 Mar 2019 09:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tawD2D2yhPxJ6jVXdtHNzTe8sO1hTye0ddBxemZiBK0=; b=YqjdboxfbzNopV2x9tMkBvHEJbeEETBfuKrR724GZBynKUEkKw8bhWCs/cXMaZaqh5 SqPg4ybL65uJ3DELHxUp1gO18+ChmybO41/MrzeHwf67CE7ifx5j8OZ/wrhB/uyVHK7C LscohqQm2NR/vhYni5KBEmiOn6kJYmhlBwBa6n+x9xAqVgzYfBPc6I9oGkGZ452XXSM3 DERK2nDBJUYXoh5ioWq7qES+9dHLOlH6lr7QopZLcyaSR9zM9lPn9O89HVa6146Le78L gfADH6PaRS/S6+otmKDpA9/ZARjKj+lWSYH8iprM9tsVNeLMedjCNnJJ9QzjnyekXqTM 3DqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tawD2D2yhPxJ6jVXdtHNzTe8sO1hTye0ddBxemZiBK0=; b=BiGBCBINT5XvLWnjZGdrLMLIjssdYH+Iv6fIGZKfWZMHJi89khmr4gGlKXZrTbajo4 YjR7xi7QysD7wO5/+K9JbmT119z5QVVpNL1xQcjmIxGtsqBRKQvqXo2FPR23N7wZwH5s zfJgzRllYmuDXSigAd8BBvMoXYTm1tgOXfCPFv+hVSaAKd/HyQiaxB+u8W05LGQ59lAZ 133qsJ0B7EQ2mk7WtEPf8s4Rbq0A1uKmwuvXVLZlTa29yjFtSrMQPP4M27+/KmcShhXv RDKfoNRv3pPMbmmqRlpilnxLSUyVHKBWXv31YIyINJzrdr4zBQY44mlTms9Edfp0Uk7W 3p1w== X-Gm-Message-State: APjAAAXfO4QzScYY7MXAXbRssTQoBljELDvvT2TJNFaA62Z2Zv0IK2+V 4OOyivhJmaAqa8ldWN/ZpxQNdt/MjI9QGBOyAyl8qHAZBQqDJw== X-Received: by 2002:a05:660c:3d1:: with SMTP id c17mr2338356itl.166.1552407695236; Tue, 12 Mar 2019 09:21:35 -0700 (PDT) MIME-Version: 1.0 References: <0000000000004cfa120583e1dfc3@google.com> <7dd5ffca-803d-9d5e-7fa4-f9eed2249d26@hartkopp.net> In-Reply-To: From: Dmitry Vyukov Date: Tue, 12 Mar 2019 17:21:24 +0100 Message-ID: Subject: Re: WARNING in hsr_forward_skb To: Oliver Hartkopp Cc: syzbot , arvid.brodin@alten.se, Jens Axboe , Jens Axboe , David Miller , Christoph Hellwig , linux-block@vger.kernel.org, linux-can@vger.kernel.org, LKML , Ming Lei , Marc Kleine-Budde , netdev , syzkaller-bugs Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 12, 2019 at 5:09 PM Dmitry Vyukov wrote: > > On Tue, Mar 12, 2019 at 1:02 PM Oliver Hartkopp wrote: > > > > Hi all, > > > > I'm not sure why a Kernel 4.12.0-rc2+ is used here, but I do not get any > > problems on the my latest 5.0.0-06622-g1fc1cd8399ab tree and I strongly > > assume this patch showing up in 4.12-rc6 > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit?id=74b7b490886852582d986a33443c2ffa50970169 > > > > fixes the problem. > > > Hi Oliver, > > You can see how bisection progressed and got to 4.12.0-rc2+ in the > bisection log. > > The commit that it come up with looks unrelated. > I've started collecting such cases at: > https://github.com/google/syzkaller/issues/1051 > and added for this case: > > ===== > Bisected to wrong commit. > Root cause: broken kernel boots, bugs that happen on all tests. > Boot is broken for several releases with "WARNING in hsr_forward_skb", > this switches to a bug that happens during every test "INFO: trying to > register non-static key in can_notifier", which then leads to a > completely random commit. > ===== Broken boots did not happen here. "WARNING in hsr_forward_skb" is the crash that we pursued, so it started correctly. But then diverged to an unrelated "INFO: trying to register non-static key in can_notifier". > > On 3/12/19 9:57 AM, syzbot wrote: > > > syzbot has bisected this bug to: > > > > > > commit ab42f35d9cb5ac49b5a2a11f940e74f58f207280 > > > Author: Ming Lei > > > Date: Fri May 26 11:53:19 2017 +0000 > > > > > > blk-mq: merge bio into sw queue before plugging > > > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16e68713200000 > > > start commit: ab42f35d blk-mq: merge bio into sw queue before plugging > > > git tree: upstream > > > final crash: https://syzkaller.appspot.com/x/report.txt?x=15e68713200000 > > > console output: https://syzkaller.appspot.com/x/log.txt?x=11e68713200000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=5e7dc790609552d7 > > > dashboard link: > > > https://syzkaller.appspot.com/bug?extid=fdce8f2a8903f3ba0e6b > > > userspace arch: amd64 > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15f6d1fd400000 > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17290fdd400000 > > > > > > Reported-by: syzbot+fdce8f2a8903f3ba0e6b@syzkaller.appspotmail.com > > > Fixes: ab42f35d ("blk-mq: merge bio into sw queue before plugging") > > > > -- > > You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/7dd5ffca-803d-9d5e-7fa4-f9eed2249d26%40hartkopp.net. > > For more options, visit https://groups.google.com/d/optout.