Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp2308487imc; Tue, 12 Mar 2019 11:04:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqy7uuNcSvWyBnimSoglYu0bN7KtinWAy4xIC911cF7BlsIvVjox5VYQmdcplCTOVpWDArVD X-Received: by 2002:a65:5286:: with SMTP id y6mr19032241pgp.310.1552413896005; Tue, 12 Mar 2019 11:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552413895; cv=none; d=google.com; s=arc-20160816; b=AWTFc/5eVzK9sj7WPcZeSf8LRzhixlW/TK1NDIp7wIw+KFKw93IMxPsGUMlzNFKK4C 5ZmdwBaQUH4u/X07Pmlxxd6W7sk0Y1nC3FKk1M+GHJB4fFj4CXcOTDIhBiCsxyv4U4xz Q0Kek4+CLDvVgFgcA7nxOYo5HApRjuwllzQ6PHj3t5rIrFr77s1cqcet8B0btEo1b0Qd RTEL5wwvkigEFmx6sBbHxDqPYzJYr3/VgZWnmhTSXzuEMOlN/DF+YZyK0jnnbSWHpMFG A294E7R4Jrr8Lr9eUIGR1ipGhFZk98QZdeRKDlRuGTiW7gVAbJb2E4yg1T51xMokGEYK kU4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=UcHosj4VySIf5alJ111JhnuU54pjY31Yq5QSLyDQ2JY=; b=EaX992w1yLfn5WCWvZFrY8yKD65hlWv1BktkgGtOs79Qm0EU6G5HASc8J0aWdXk8Ws ffcHx0ShkAOZkWDI3Og575mYm/+0zpFSgF3Tq985p4ShQ/G6wuBw9Ow2i04TmwgBDE4e Gbh62/H8Yk45Z5iZt7YzufiXCmlUvrIKrBfTLPCbc3jJeE8bOv26DfPhzbiHCkK1Xzqc 5OIpm46grAOiEkeHT64gjSRyfIKcjwINJ1LkAeWt3U+DrELPeuj75BMRkDUy2PrOMbng uVwYrR0yQBcvm1SA68zkr1HRiNKAacVPSdj3pyCEW+OO9AIYaFiI0R0gbP4ILFoP38SA 6nkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j7si8899514plb.349.2019.03.12.11.04.40; Tue, 12 Mar 2019 11:04:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727832AbfCLSDS (ORCPT + 99 others); Tue, 12 Mar 2019 14:03:18 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47506 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727699AbfCLSDQ (ORCPT ); Tue, 12 Mar 2019 14:03:16 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E851A78; Tue, 12 Mar 2019 11:03:15 -0700 (PDT) Received: from [10.1.196.92] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E83E33F59C; Tue, 12 Mar 2019 11:03:14 -0700 (PDT) Subject: Re: [PATCH 0/4] irqchip/gic-v3-its: free_lpi_range tweaks To: Rasmus Villemoes , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20190312173350.4025-1-linux@rasmusvillemoes.dk> From: Marc Zyngier Openpgp: preference=signencrypt Autocrypt: addr=marc.zyngier@arm.com; prefer-encrypt=mutual; keydata= mQINBE6Jf0UBEADLCxpix34Ch3kQKA9SNlVQroj9aHAEzzl0+V8jrvT9a9GkK+FjBOIQz4KE g+3p+lqgJH4NfwPm9H5I5e3wa+Scz9wAqWLTT772Rqb6hf6kx0kKd0P2jGv79qXSmwru28vJ t9NNsmIhEYwS5eTfCbsZZDCnR31J6qxozsDHpCGLHlYym/VbC199Uq/pN5gH+5JHZyhyZiNW ozUCjMqC4eNW42nYVKZQfbj/k4W9xFfudFaFEhAf/Vb1r6F05eBP1uopuzNkAN7vqS8XcgQH qXI357YC4ToCbmqLue4HK9+2mtf7MTdHZYGZ939OfTlOGuxFW+bhtPQzsHiW7eNe0ew0+LaL 3wdNzT5abPBscqXWVGsZWCAzBmrZato+Pd2bSCDPLInZV0j+rjt7MWiSxEAEowue3IcZA++7 ifTDIscQdpeKT8hcL+9eHLgoSDH62SlubO/y8bB1hV8JjLW/jQpLnae0oz25h39ij4ijcp8N t5slf5DNRi1NLz5+iaaLg4gaM3ywVK2VEKdBTg+JTg3dfrb3DH7ctTQquyKun9IVY8AsxMc6 lxl4HxrpLX7HgF10685GG5fFla7R1RUnW5svgQhz6YVU33yJjk5lIIrrxKI/wLlhn066mtu1 DoD9TEAjwOmpa6ofV6rHeBPehUwMZEsLqlKfLsl0PpsJwov8TQARAQABtCNNYXJjIFp5bmdp ZXIgPG1hcmMuenluZ2llckBhcm0uY29tPokCOwQTAQIAJQIbAwYLCQgHAwIGFQgCCQoLBBYC AwECHgECF4AFAk6NvYYCGQEACgkQI9DQutE9ekObww/+NcUATWXOcnoPflpYG43GZ0XjQLng LQFjBZL+CJV5+1XMDfz4ATH37cR+8gMO1UwmWPv5tOMKLHhw6uLxGG4upPAm0qxjRA/SE3LC 22kBjWiSMrkQgv5FDcwdhAcj8A+gKgcXBeyXsGBXLjo5UQOGvPTQXcqNXB9A3ZZN9vS6QUYN TXFjnUnzCJd+PVI/4jORz9EUVw1q/+kZgmA8/GhfPH3xNetTGLyJCJcQ86acom2liLZZX4+1 6Hda2x3hxpoQo7pTu+XA2YC4XyUstNDYIsE4F4NVHGi88a3N8yWE+Z7cBI2HjGvpfNxZnmKX 6bws6RQ4LHDPhy0yzWFowJXGTqM/e79c1UeqOVxKGFF3VhJJu1nMlh+5hnW4glXOoy/WmDEM UMbl9KbJUfo+GgIQGMp8mwgW0vK4HrSmevlDeMcrLdfbbFbcZLNeFFBn6KqxFZaTd+LpylIH bOPN6fy1Dxf7UZscogYw5Pt0JscgpciuO3DAZo3eXz6ffj2NrWchnbj+SpPBiH4srfFmHY+Y LBemIIOmSqIsjoSRjNEZeEObkshDVG5NncJzbAQY+V3Q3yo9og/8ZiaulVWDbcpKyUpzt7pv cdnY3baDE8ate/cymFP5jGJK++QCeA6u6JzBp7HnKbngqWa6g8qDSjPXBPCLmmRWbc5j0lvA 6ilrF8m5Ag0ETol/RQEQAM/2pdLYCWmf3rtIiP8Wj5NwyjSL6/UrChXtoX9wlY8a4h3EX6E3 64snIJVMLbyr4bwdmPKULlny7T/R8dx/mCOWu/DztrVNQiXWOTKJnd/2iQblBT+W5W8ep/nS w3qUIckKwKdplQtzSKeE+PJ+GMS+DoNDDkcrVjUnsoCEr0aK3cO6g5hLGu8IBbC1CJYSpple VVb/sADnWF3SfUvJ/l4K8Uk4B4+X90KpA7U9MhvDTCy5mJGaTsFqDLpnqp/yqaT2P7kyMG2E w+eqtVIqwwweZA0S+tuqput5xdNAcsj2PugVx9tlw/LJo39nh8NrMxAhv5aQ+JJ2I8UTiHLX QvoC0Yc/jZX/JRB5r4x4IhK34Mv5TiH/gFfZbwxd287Y1jOaD9lhnke1SX5MXF7eCT3cgyB+ hgSu42w+2xYl3+rzIhQqxXhaP232t/b3ilJO00ZZ19d4KICGcakeiL6ZBtD8TrtkRiewI3v0 o8rUBWtjcDRgg3tWx/PcJvZnw1twbmRdaNvsvnlapD2Y9Js3woRLIjSAGOijwzFXSJyC2HU1 AAuR9uo4/QkeIrQVHIxP7TJZdJ9sGEWdeGPzzPlKLHwIX2HzfbdtPejPSXm5LJ026qdtJHgz BAb3NygZG6BH6EC1NPDQ6O53EXorXS1tsSAgp5ZDSFEBklpRVT3E0NrDABEBAAGJAh8EGAEC AAkFAk6Jf0UCGwwACgkQI9DQutE9ekMLBQ//U+Mt9DtFpzMCIHFPE9nNlsCm75j22lNiw6mX mx3cUA3pl+uRGQr/zQC5inQNtjFUmwGkHqrAw+SmG5gsgnM4pSdYvraWaCWOZCQCx1lpaCOl MotrNcwMJTJLQGc4BjJyOeSH59HQDitKfKMu/yjRhzT8CXhys6R0kYMrEN0tbe1cFOJkxSbV 0GgRTDF4PKyLT+RncoKxQe8lGxuk5614aRpBQa0LPafkirwqkUtxsPnarkPUEfkBlnIhAR8L kmneYLu0AvbWjfJCUH7qfpyS/FRrQCoBq9QIEcf2v1f0AIpA27f9KCEv5MZSHXGCdNcbjKw1 39YxYZhmXaHFKDSZIC29YhQJeXWlfDEDq6nIhvurZy3mSh2OMQgaIoFexPCsBBOclH8QUtMk a3jW/qYyrV+qUq9Wf3SKPrXf7B3xB332jFCETbyZQXqmowV+2b3rJFRWn5hK5B+xwvuxKyGq qDOGjof2dKl2zBIxbFgOclV7wqCVkhxSJi/QaOj2zBqSNPXga5DWtX3ekRnJLa1+ijXxmdjz hApihi08gwvP5G9fNGKQyRETePEtEAWt0b7dOqMzYBYGRVr7uS4uT6WP7fzOwAJC4lU7ZYWZ yVshCa0IvTtp1085RtT3qhh9mobkcZ+7cQOY+Tx2RGXS9WeOh2jZjdoWUv6CevXNQyOUXMM= Organization: ARM Ltd Message-ID: Date: Tue, 12 Mar 2019 18:03:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190312173350.4025-1-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rasmus, On 12/03/2019 17:33, Rasmus Villemoes wrote: > I noticed that the O(n log n) behaviour of free_lpi_range could easily > be made O(n) (patch 4), though I don't suppose n is ever large enough > to actually matter. While there, I also stumbled on two other > micro-optimizations (2 and 3). n is usually in the range 1 .. nr_cpus, so pretty small, even on the biggest machines we have around (256 threads). And actually, nobody ever frees LPIs, because hey, why would you? > Then while writing the commit log for the last patch, I noticed that > the cmp callback I was removing was actually buggy, so I went back and > added a patch in front suitable for -stable. I'll leave it to others > to decide if it's important enough for that. Thanks for that. I'll have a look at the whole thing anyway (I've just glanced over it so far). > Please note that this is only compile-tested. Right, this needs some actual testing then. /me needs to build a guest that shakes the allocator a bit. Cheers, M. -- Jazz is not dead. It just smells funny...