Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp2316458imc; Tue, 12 Mar 2019 11:13:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUzUvxyB4LrFEoxP15hYWp9KajdS9Y3G7gO9ZeTPHT457Nu8Y/hAKOCDT1XNW4z9LzEsgN X-Received: by 2002:a81:8603:: with SMTP id w3mr12361799ywf.212.1552414421200; Tue, 12 Mar 2019 11:13:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552414421; cv=none; d=google.com; s=arc-20160816; b=UUK0Orr8yhEYkY5/Q7t6sJZO0cK/BHzOGB4LAkij+oXux20I/CKxW/jSPmHDt+v19D bWv3/mSEAgIm9PZvTr5CCVwtFb47SFZmbzqrD/4+8nE6zheI51fml9wzlYdGF0F/BKDt RQ4kaIptdG65FcoNhYUfN1l1RNQVDJcSe4shv+BoomAIpiQTiT+mCI3zXj8I5Y3dqqnI BiSGg/WQGcTTselyDvdCsHUsIWeT+PW76NkS0cPJhFI5S/NkgMtWv9zQelI5m1gU/F4J Yf6KQhprGuuve90Y7W8v8bsqR/zFaz5/bWJq5rTC2LGOBnw9q5+BQuuUyy333HHx+Org 5HbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=j2XUWhrAN2bLgU2YP/B48KRr3/6J0X/WOlHjS6VtXOs=; b=aQuztRoPPF1sny3F10Th20THBuvdsg4xBf5a7JsviAvxVi56/5wAMijGDelCu/1Pdx 9K0A0h+SvhLgbJ0bSETKNAE8JJ0+tVngV2j4J+EthGfsWoHDNqn5vNtvz2SgI55IbvvB MwZsW5tkeo65cefH3s5z4XlipqLTb+O+pc9CihAAR3h870sIpkvqU+j9BDi+D74G/9LA pubMpQNWQ/PW25hNpNFL4mqeXaVooIf4pwQdZ45gVTj/pQPInncaI374kwll1WtgZmvM 6DvnO5JmQpKOZeRrsqBMYrPAWj3Z82SdVWC0vQPdVels8oDg7TOMVqYLK4OOzGDMgL8h HK5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JYVL7dDA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s83si5617330ybb.457.2019.03.12.11.13.26; Tue, 12 Mar 2019 11:13:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JYVL7dDA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbfCLSNI (ORCPT + 99 others); Tue, 12 Mar 2019 14:13:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:44992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbfCLRLc (ORCPT ); Tue, 12 Mar 2019 13:11:32 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B68CC217D9; Tue, 12 Mar 2019 17:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552410691; bh=gYXwQsI/GvPSNWue6qKYRRaQO3smlpVoxNAl4VRUH90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JYVL7dDArsRVTuZ/nZQosQA3P7Z8fdscxWY1u5Cp5HIVWymLFO9E2dhwxIkbpfIdO mekLlN5wo/xglKWclhi4yHOYJYyuT63tMyFIKVNZd80QMXNhN3Sa6Ek2IRTbsCQ3ur yFLMAtrPPalWh+QVtm78Y/tINpi/RM1AolLBh0eo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Kiszka , Ulf Hansson , Wei Xu Subject: [PATCH 5.0 08/25] arm64: dts: hikey: Give wifi some time after power-on Date: Tue, 12 Mar 2019 10:08:46 -0700 Message-Id: <20190312170404.167689395@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170403.643852550@linuxfoundation.org> References: <20190312170403.643852550@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jan Kiszka commit 83b944174ad79825ae84a47af1a0354485b24602 upstream. Somewhere along recent changes to power control of the wl1835, power-on became very unreliable on the hikey, failing like this: wl1271_sdio: probe of mmc2:0001:1 failed with error -16 wl1271_sdio: probe of mmc2:0001:2 failed with error -16 After playing with some dt parameters and comparing to other users of this chip, it turned out we need some power-on delay to make things stable again. In contrast to those other users which define 200 ms, the hikey would already be happy with 1 ms. Still, we use the safer 10 ms, like on the Ultra96. Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") Cc: #4.12+ Signed-off-by: Jan Kiszka Acked-by: Ulf Hansson Signed-off-by: Wei Xu Signed-off-by: Greg Kroah-Hartman --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + 1 file changed, 1 insertion(+) --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts @@ -118,6 +118,7 @@ reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; clocks = <&pmic>; clock-names = "ext_clock"; + post-power-on-delay-ms = <10>; power-off-delay-us = <10>; };