Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] tpm: Make timeout logic simpler and more robust
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     James Bottomley <James.Bottomley@HansenPartnership.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Peter =?ISO-8859-1?Q?H=FCwe?= <PeterHuewe@gmx.de>
Cc:     Calvin Owens <calvinowens@fb.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@fb.com
Date:   Tue, 12 Mar 2019 14:32:00 -0400
In-Reply-To: <1552410856.3083.28.camel@HansenPartnership.com>
References: <358e89ed2b766d51b5f57abf31ab7a925ac63379.1552348123.git.calvinowens@fb.com>
         <1552350463.23859.8.camel@HansenPartnership.com>
         <20190312125028.GC9243@linux.intel.com>
         <1552401766.3083.3.camel@HansenPartnership.com>
         <1552409969.24794.68.camel@linux.ibm.com>
         <1552410856.3083.28.camel@HansenPartnership.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-Id: <1552415520.24794.87.camel@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-03-12 at 10:14 -0700, James Bottomley wrote:

> > > However, I am saying we should root cause this problem rather than
> > > take a blind shot at the apparent timeout complexity.  My timeout
> > > instability is definitely related to the polling adjustments, so
> > > it's not unreasonable to think Facebooks might be as well.
> > 
> > James, I thought Peter sent you a tis "debug" tool to help you debug
> > the problem you're seeing.  Whatever happened?

https://patchwork.kernel.org/patch/10520247/#22107607

> 
> No, not seen one.  I have tried to debug the problem, but it's really
> odd: my TPM is a polled nuvoton (so no irq line).  If you poll the data
> ready bit on my TPM too often, it simply drops off the bus and every
> TPM operation after that times out.  The only way to recover is to
> reboot.
> 
> James
>