Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Christopher Lameter <cl@linux.com>
CC:     "Tobin C. Harding" <tobin@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Pekka Enberg <penberg@cs.helsinki.fi>,
        "Matthew Wilcox" <willy@infradead.org>,
        Tycho Andersen <tycho@tycho.ws>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 02/15] slub: Add isolate() and migrate() methods
Thread-Topic: [RFC 02/15] slub: Add isolate() and migrate() methods
Thread-Index: AQHU1WWOzoo+8Mo/g0+TXm2HFlFybKYGiOoAgADmRICAAO46AA==
Date:   Tue, 12 Mar 2019 18:47:57 +0000
Message-ID: <20190312184754.GB31407@tower.DHCP.thefacebook.com>
References: <20190308041426.16654-1-tobin@kernel.org>
 <20190308041426.16654-3-tobin@kernel.org>
 <20190311215106.GA7915@tower.DHCP.thefacebook.com>
 <01000169702ee357-fe8b85e5-e601-41da-8ba2-25e8b7db52eb-000000@email.amazonses.com>
In-Reply-To: <01000169702ee357-fe8b85e5-e601-41da-8ba2-25e8b7db52eb-000000@email.amazonses.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::2:d3a0]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: af1a46df-4e5a-440b-5e95-08d6a71b3eab
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB3510;
x-ms-traffictypediagnostic: BYAPR15MB3510:
x-microsoft-exchange-diagnostics: 1;BYAPR15MB3510;20:OfzLOrUcUBv2Fd2vakFl3InVBLbYWE/Irtqtn3Y3w8O7+VeGuSmWyjeBfJA/7AizCUEhkgLnQvRuqx4E1Z32H28NK2y75/9qHbVCSiK+4O1qPO9fYNeTTH4arDhP0h9skf7RogYxUpvLS92869H+FOp7u+dPYGTV8FB0R2t/Cyc=
x-microsoft-antispam-prvs: <BYAPR15MB3510E8CA0DAF9B933CA93EC8BE490@BYAPR15MB3510.namprd15.prod.outlook.com>
x-forefront-prvs: 09749A275C
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(396003)(136003)(366004)(39860400002)(376002)(199004)(189003)(54094003)(256004)(386003)(14444005)(6506007)(25786009)(54906003)(1076003)(6436002)(7736002)(102836004)(68736007)(6486002)(5660300002)(71190400001)(6246003)(229853002)(14454004)(81156014)(81166006)(9686003)(76176011)(305945005)(11346002)(478600001)(476003)(8676002)(446003)(6916009)(4326008)(46003)(99286004)(6512007)(8936002)(186003)(97736004)(53936002)(486006)(316002)(106356001)(93886005)(71200400001)(105586002)(86362001)(52116002)(33656002)(2906002)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB3510;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: oqcbNJ/DPl4R11an69bG1xo6rHxmu+XOK04/Nw3L1eJ994FG1De6IakPnkS6DlpOfrcMgPo7MC4/FQRy8iqM05W/JE7/rTqFr/QCB5G7BHOcNM7FEXV1SBg7wMsGIQPSnp48bYq0oECrWwnF52LwICtR+Xj9RL2bBGoxHEBLf8WLpMukFHaZGDesvnTlAWxng442Q4qT2W23vv8cF/HqZ8csdtf3UMho3T1AxKd6OYi3j63nzT3NVeJ4xEGeYjdrN0dj8wsOIPqnp261zE6PSoJBMpzXOevmjpctNyv3ZTPGUQ7A1e1jOPL/Kv/JiqdwSngccZdIrtteXTiTlbJyBiwiNOhKZ0qMnXZP2BF2xslq6lFiai4e5ngEdSmjYNzbJhdmsNVbDO6lINAtuFRWA+16x9QuIKZYrUw8Fm0oUiM=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6569EAB69B17AE42B6B6270C7F703CBE@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: af1a46df-4e5a-440b-5e95-08d6a71b3eab
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2019 18:47:57.9999
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3510
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-12_10:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 12, 2019 at 04:35:15AM +0000, Christopher Lameter wrote:
> On Mon, 11 Mar 2019, Roman Gushchin wrote:
>=20
> > > --- a/mm/slub.c
> > > +++ b/mm/slub.c
> > > @@ -4325,6 +4325,34 @@ int __kmem_cache_create(struct kmem_cache *s, =
slab_flags_t flags)
> > >  	return err;
> > >  }
> > >
> > > +void kmem_cache_setup_mobility(struct kmem_cache *s,
> > > +			       kmem_cache_isolate_func isolate,
> > > +			       kmem_cache_migrate_func migrate)
> > > +{
> >
> > I wonder if it's better to adapt kmem_cache_create() to take two additi=
onal
> > argument? I suspect mobility is not a dynamic option, so it can be
> > set on kmem_cache creation.
>=20
> One other idea that prior versions of this patchset used was to change
> kmem_cache_create() so that the ctor parameter becomes an ops vector.
>=20
> However, in order to reduce the size of the patchset I dropped that. It
> could be easily moved back to the way it was before.

Understood. I like the idea of an ops vector, but it can be done later,
agree.

>=20
> > > +	/*
> > > +	 * Sadly serialization requirements currently mean that we have
> > > +	 * to disable fast cmpxchg based processing.
> > > +	 */
> >
> > Can you, please, elaborate a bit more here?
>=20
> cmpxchg based processing does not lock the struct page. SMO requires to
> ensure that all changes on a slab page can be stopped. The page->lock wil=
l
> accomplish that. I think we could avoid dealing with actually locking the
> page with some more work.

Thank you for the explanation!