Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp2356832imc; Tue, 12 Mar 2019 12:05:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNmgKE8jvV0SO3Qp60iRPVpS4hUNDPIufMPjD5uNIUBcGaWTSYkSVfZFD0PEXu8gTP83/E X-Received: by 2002:a63:535c:: with SMTP id t28mr36854433pgl.128.1552417554669; Tue, 12 Mar 2019 12:05:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552417554; cv=none; d=google.com; s=arc-20160816; b=XygTuNQW3VsIUZDq/r0HuqApEHAq+gpzcFv+w5uCoBhOa3hOlX8w8KfzvZOyJ62cLR 5RqEmUaDmNSqcODdXZKu6Z/3M4H2qtqpkWkP5NwSbbJ8/1S4JzrgTq6aXlq7M48YwRK5 Uh18uu1r1+P0Pi6/crXdfVdkTVx2VO2vZFAWmy4h27oZv+f/cuP3+pX7mHvu6MgNxd2q Ywii6pYXbQAovAdp92LBVzMOOglkFBE0K6yC1PoSBTyJxoruHnD1bf8qLEdMbOWeQe4q wN7GInWtq8sc8JvxUCuoLwOBZvw8A16XfyUU2CUbZyOb842EaiCAZ13jd7lVGkzM1V1n yh9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=o1h8G2iyppaSn5rKfpYOUBhQRQuqezP7Kg2IErjp+EA=; b=MaQSS6XOLkywsb/px/ibz2Wl+rn9pk0D+d6VhiFmacpkC63o549zPUgK2UPDoBeSFF jJExD/xYXP/J+xSn9ofmOo+c5MLel5SNkxlT3zMD0dk5HirqVnwhzRPsUPrj9yYP9bw6 VF0UWnwQs8B7LYWXFkimQK6Uwll97hnhnr1SCB2DUrBquFZG4RLkVVHKfkACoG5JQ+ZB O1QReAyLJ1PCZVL5LwXtGJSRzbsb7GoSW3GY8UsgCNMEnpTHVGqpq+7LoFTBrQ0fUWrj 5b3QTWpNoMgj7RtqZGbLvXwLdyDFiiJJA2l6soS5DdhITA9jUyiZbaKUbug73BOKEHde VzhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y16si8027263pgl.17.2019.03.12.12.05.38; Tue, 12 Mar 2019 12:05:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727134AbfCLTD4 (ORCPT + 99 others); Tue, 12 Mar 2019 15:03:56 -0400 Received: from mail-vk1-f196.google.com ([209.85.221.196]:39530 "EHLO mail-vk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726815AbfCLTDz (ORCPT ); Tue, 12 Mar 2019 15:03:55 -0400 Received: by mail-vk1-f196.google.com with SMTP id i68so923961vke.6; Tue, 12 Mar 2019 12:03:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o1h8G2iyppaSn5rKfpYOUBhQRQuqezP7Kg2IErjp+EA=; b=EHGP08rL4yyEBQmnct5qRGCau3m54e/qoobYz6xhmJv9w+l3VI9Z86j7C+lWHGcZaW lpAiTQ5LbCFW2i/m7VVtbrWuEXIhEevuRy4Z/Wp9Y2zr9dJofukDnmJym93gCiaoo8w+ skXv7/QjyNcgRaaJt/z5qlKi66qtV3oVJFcKzkxAGJqSXq/ChvN8zmpUZ38b+SUyieRq AMHsXm5+M1AbvT5WQh/Fyqd4KSYU6WvW73t9oImKMhbGYOmFrt4vgIdYsjQmu4KnCzD4 lgLeaaG97KM9FdSL4oB0A6r2YvGaHl5HWCzrCZbqpHyae4H4unxVa58bYKiZDDJLgO/t Ghww== X-Gm-Message-State: APjAAAVZvl8yLthEbq51SeeBxixHs/9pUdl5iPx7sEV2mm585/BUsloN oE7kOI66OP9kHtjqy8T2+ox/EU8K9Cw15LoBtP0= X-Received: by 2002:a1f:95d5:: with SMTP id x204mr20915557vkd.72.1552417433842; Tue, 12 Mar 2019 12:03:53 -0700 (PDT) MIME-Version: 1.0 References: <1552330521-4276-1-git-send-email-info@metux.net> <1552330521-4276-26-git-send-email-info@metux.net> In-Reply-To: <1552330521-4276-26-git-send-email-info@metux.net> From: Geert Uytterhoeven Date: Tue, 12 Mar 2019 20:03:42 +0100 Message-ID: Subject: Re: [PATCH 26/42] drivers: gpio: rcar: pendantic formatting To: "Enrico Weigelt, metux IT consult" Cc: Linux Kernel Mailing List , Linus Walleij , Bartosz Golaszewski , Andrew Jeffery , Florian Fainelli , Scott Branden , bcm-kernel-feedback-list@broadcom.com, hoan@os.amperecomputing.com, Orson Zhai , Baolin Wang , Lyra Zhang , keguang.zhang@gmail.com, vz@mleia.com, Matthias Brugger , Thierry Reding , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Masahiro Yamada , Jun Nie , Shawn Guo , "open list:GPIO SUBSYSTEM" , linux-mips@vger.kernel.org, Linux PWM List , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" , linux-tegra , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC linux-renesas-soc On Mon, Mar 11, 2019 at 7:57 PM Enrico Weigelt, metux IT consult wrote: > a tab sneaked in, where it shouldn't be. > > Signed-off-by: Enrico Weigelt, metux IT consult With Thierry's comments addressed: Reviewed-by: Geert Uytterhoeven > --- a/drivers/gpio/gpio-rcar.c > +++ b/drivers/gpio/gpio-rcar.c > @@ -490,7 +490,7 @@ static int gpio_rcar_probe(struct platform_device *pdev) > irq_chip->irq_unmask = gpio_rcar_irq_enable; > irq_chip->irq_set_type = gpio_rcar_irq_set_type; > irq_chip->irq_set_wake = gpio_rcar_irq_set_wake; > - irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND; > + irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND; > > ret = gpiochip_add_data(gpio_chip, p); > if (ret) { Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds