Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3Ajz0LXxYm2zM1Aq9HDBDIfej/LSx+4OfEezUN45?=
 =?us-ascii?q?9isYplN5qZps2zYB7h7PlgxGXEQZ/co6odzbaP6+a4ACQp2tWoiDg6aptCVh?=
 =?us-ascii?q?sI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFR?=
 =?us-ascii?q?rhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTagfb9+Ngm6oRjMvcQKnIVuLbo8xA?=
 =?us-ascii?q?HUqXVSYeRWwm1oJVOXnxni48q74YBu/SdNtf8/7sBMSar1cbg2QrxeFzQmLn?=
 =?us-ascii?q?s65Nb3uhnZTAuA/WUTX2MLmRdVGQfF7RX6XpDssivms+d2xSeXMdHqQb0yRD?=
 =?us-ascii?q?+v9LlgRgP2hygbNj456GDXhdJ2jKJHuxKquhhzz5fJbI2JKPZye6XQct0ARW?=
 =?us-ascii?q?pFQ81fSSpPDI2hZIcLFuYNI+JVo4z7qlATrxWxGBOsCfvyxDFWiH/43a403e?=
 =?us-ascii?q?ovHg7J3gMvA90AvW/IrNj3LqoeTfy5wafKwDjFcvhY2S396I/Nch05vP+MQa?=
 =?us-ascii?q?x/cdLRyUYxEQPOk0ieqYn/MDOR0uQCrWia5PdnWOK0lmEnsBp8oiSvx8gwio?=
 =?us-ascii?q?nJgZgZylbf9Spj2oo1Ktq4SFBibNOiDZBeuSaaN45sTcMjRWFloCU6xaMcuZ?=
 =?us-ascii?q?69YicKzI4rxxnFa/yIdYWD/xHtVP6JLDtli39od6izihav/US61OHxWde43E?=
 =?us-ascii?q?xXoidDj9LCrGoC1wbJ5ciCUvZ9+0Ch1iuR2A3L8eFEJFw0lbLcK5483r48jp?=
 =?us-ascii?q?oTvlrHHi/xgEj2kLWZdl8l+ui18OTreKnmp5+AOI90jQHyKKIuldCkAeskKA?=
 =?us-ascii?q?QOWmmb+eCk2L3i+032XqlKg+UrnqTWv53WP8QWqrOjDwNL3Ysv9QyzAyq+3N?=
 =?us-ascii?q?Qdh3YHLVZFeBydj4juPlHDOOv4Auqkg1m3jDdqx+zJPr3mApnXKHjDi63uca?=
 =?us-ascii?q?xy605b1go/1cpf6I5MCrEdPPLzXVf8tN7fDh85KQO0xeDnB8tm1o4FW2KPBL?=
 =?us-ascii?q?SWMLnIvV+N+O0lO/OMa5MNuDbhN/gl4ObjjWcjll8AeamkxoMXZ2qlHvRiOk?=
 =?us-ascii?q?mZZH3sgtAbEWgUpAYxUOvqiFiaWz5Je3myR7485i08CI++E4jDXpqigKaA3C?=
 =?us-ascii?q?egBZBWfnpJCkqNEXfzb4WEX+0DZz6MLcN7lTwET7ehQZc71R6yrA/616ZnLu?=
 =?us-ascii?q?3M9y0Dq53j0Nl15+vOlRA97jF0Ecud3H+XT21unWMHWSU23KZhrkx50FuD1r?=
 =?us-ascii?q?J4g/NAH9xJ+/xJShs6NYLbz+FiD9DyWwTBfsqGSVq/QdWpHysxTtQvzN8KeE?=
 =?us-ascii?q?t9BdqigQ7Z3yawAL8aiaaLBJoq/aLYxXTxINx9y3mVnJUm2nshQsJJM2C9zo?=
 =?us-ascii?q?Rl+gPTG4vAlUPRw6Stda0a2iPW3GWFx3DIuUwOFEZIWLjBFVUYYVHb5YDh71?=
 =?us-ascii?q?7GZ6enFLBiNwxG08PEIaxPPJmhoE9HT7/bMc7feCrlln+5HxeT7quFdovxY2?=
 =?us-ascii?q?EU1yibD1ILxURb5nuCNA4jFg+/rG/ESj9jD1TiZwXr6+Y64He6SFIkigKHdU?=
 =?us-ascii?q?ts05Kr9RMPw/+RUfUe2vQDoihyhS9zGQOGw9/OC9eG7zFkdaFYbMJ1tExLzk?=
 =?us-ascii?q?rFpgd9OdqmNKkkiVkAJVck93jy3gl6X90T2fMhq2knmU8rc/OV?=
Subject: Re: [PATCH] selinux: use kernel definition of PF_MAX in scripts
To:     Johannes Brechtmann <johannes@jnbr.me>,
        Paul Moore <paul@paul-moore.com>,
        Eric Paris <eparis@parisplace.org>, selinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20190312194758.6f411a8b@t440s.fritz.box>
From:   Stephen Smalley <sds@tycho.nsa.gov>
Message-ID: <30b42bae-2aef-071f-6d59-fda40d2e4ff2@tycho.nsa.gov>
Date:   Tue, 12 Mar 2019 16:16:54 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190312194758.6f411a8b@t440s.fritz.box>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/12/19 2:47 PM, Johannes Brechtmann wrote:
>  From 1892b9ff8045bac6fe166802b2d8a8a3111c1e0c Mon Sep 17 00:00:00 2001
> From: Johannes Brechtmann <johannes@jnbr.me>
> Date: Tue, 12 Mar 2019 17:50:12 +0100
> Subject: [PATCH] selinux: use kernel definition of PF_MAX in scripts
> 
> Building selinux scripts of old releases on a current host fails with:
> 
>      In file included from scripts/selinux/genheaders/genheaders.c:19:
>      ./security/selinux/include/classmap.h:245:2: error: #error New
>      address family defined, please update secclass_map.
> 
> Fix the issue by including linux/socket.h from kernel instead of
> sys/socket.h from host.
> 
> Signed-off-by: Johannes Brechtmann <johannes@jnbr.me>

Thanks, but already covered by
https://lore.kernel.org/selinux/20190225005528.28371-1-paulo@paulo.ac/

> ---
>   scripts/selinux/genheaders/genheaders.c | 2 +-
>   scripts/selinux/mdp/mdp.c               | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/selinux/genheaders/genheaders.c b/scripts/selinux/genheaders/genheaders.c
> index 1ceedea847dd..6db7e07fbc4c 100644
> --- a/scripts/selinux/genheaders/genheaders.c
> +++ b/scripts/selinux/genheaders/genheaders.c
> @@ -9,7 +9,7 @@
>   #include <string.h>
>   #include <errno.h>
>   #include <ctype.h>
> -#include <sys/socket.h>
> +#include <linux/socket.h>
>   
>   struct security_class_mapping {
>   	const char *name;
> diff --git a/scripts/selinux/mdp/mdp.c b/scripts/selinux/mdp/mdp.c
> index 073fe7537f6c..744d9fc9c0bd 100644
> --- a/scripts/selinux/mdp/mdp.c
> +++ b/scripts/selinux/mdp/mdp.c
> @@ -32,7 +32,7 @@
>   #include <stdlib.h>
>   #include <unistd.h>
>   #include <string.h>
> -#include <sys/socket.h>
> +#include <linux/socket.h>
>   
>   static void usage(char *name)
>   {
>