Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp2872430imc; Wed, 13 Mar 2019 03:31:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2ISfHqbcWuCe8bO++X+GeGbAyW931YQayi05G0dImLHAFG+wqgAPp7gu+lFzQt9yYaHEC X-Received: by 2002:a17:902:a413:: with SMTP id p19mr45827893plq.337.1552473114976; Wed, 13 Mar 2019 03:31:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552473114; cv=none; d=google.com; s=arc-20160816; b=arlqkSPCxHGvwp6YaR/rK7uq6nvZvgLRSISSM0SpsV/OgHsoNF3QcXH+GHnoAq6M8r ADbIygJT4E0j5GcIvVWlmTsdBEXYZUa880jGEhH5ZRkdmcF2LybKcTZSiEh5+elsLPbk Btengj1L76Eg116zbzWYW0hd+c07hxNTyC/nZFpC/0WEWpl/Xf2DUOKv86sO6406rQFs BQ0b88+jKPMMZLgyMA5ELTDVP9arDnijBSZMPlEelb6C+3oppVE1kVF5z/wE/uMFwOOH A7gO42Bv2WKN2oVFdelvj/nidErg9yKpmxtSmxS51gnZf+3oIE3b5HVYIr7hFdF4Wo5u E55A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=5EthRL8pJEKOJg1lHETIWhZP35/CXQKm9y2eNXtGCog=; b=uOvMIcMhGdmVeiYL3Hiwr9nGyk6Bv9SM2qxSPrTufPLau7FsaMOzMWThdM2BVMPRoD nYj81gB1UQJ5IbNrWaOwPXFzpEQ6SgjcmsGppYJsJKsEmzMvQRsUUal5/qoV1DtMHdb/ t21lBl5V6hxHeXg9gRTzATtjGU5RtKg69PFSspWH6VTecVPw1fpFCgnOX4R59szssDGC dt8f/gsMDx9mFYSUklf6AYIRIs5G7aL7pO0eh4Fwb8upKHRPhI1pL3yk8DbsOmXJsb9c WxqbhgV871bOZrWCrZby8d1WDE9JdKpXXb+k8yZyGFYQGTuzfjylUEchY/LyLtSbq1kv fV0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=BKV3KLc5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si9876140pff.191.2019.03.13.03.31.37; Wed, 13 Mar 2019 03:31:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=BKV3KLc5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726412AbfCMKaq (ORCPT + 99 others); Wed, 13 Mar 2019 06:30:46 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:6589 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbfCMKap (ORCPT ); Wed, 13 Mar 2019 06:30:45 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 13 Mar 2019 03:30:44 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 13 Mar 2019 03:30:45 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 13 Mar 2019 03:30:45 -0700 Received: from [10.21.132.148] (172.20.13.39) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 13 Mar 2019 10:30:43 +0000 Subject: Re: [PATCH v2 2/2] bus: tegra-aconnect: add system sleep callbacks To: Sameer Pujar , CC: , References: <1552452119-6574-1-git-send-email-spujar@nvidia.com> <1552452119-6574-2-git-send-email-spujar@nvidia.com> From: Jon Hunter Message-ID: Date: Wed, 13 Mar 2019 10:30:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552452119-6574-2-git-send-email-spujar@nvidia.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1552473044; bh=5EthRL8pJEKOJg1lHETIWhZP35/CXQKm9y2eNXtGCog=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=BKV3KLc5t/+vvvQeCxDJmMfkcBZUjofY/pDo4RKJJ+9HCcZNA6w666J1307Xa+BfF YPPa++1u7m/eVarzZOIJkMr7n5HGe9WwirLLv76IGSNE4drXbQc0CsuZyg/du0Jd60 3pEk7DIx30N8kNNNKciTxTqd5BbXWHZFh0JgVjmrvOZwyTx+aFwjIxxP5yWw2ZSs88 v4OF9Hk7VAgpKPwCoeVr8uK7PYi+3B4cGXvJGqe91gCrVzyxxAs1HR/oroD2tdoNPo SDQ42h5sOOxQkkpnyYyCM2vJGDxE6Sug4MRvrhWHJACtLQjB5ynxRUS1qqrYQD95Ng qV5L11BCiSJ9Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/03/2019 04:41, Sameer Pujar wrote: > pm_runtime_force_suspend() and pm_runtime_force_resume() are used as system > sleep noirq suspend and resume callbacks. If the driver is active till late > suspend, where runtime PM cannot run, force suspend is essential for the > device. This makes sure that the device is put into low power state during > system wide PM transitions to sleep states. > > Signed-off-by: Sameer Pujar > --- > drivers/bus/tegra-aconnect.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bus/tegra-aconnect.c b/drivers/bus/tegra-aconnect.c > index 9349157..ac58142 100644 > --- a/drivers/bus/tegra-aconnect.c > +++ b/drivers/bus/tegra-aconnect.c > @@ -94,6 +94,8 @@ static int tegra_aconnect_runtime_suspend(struct device *dev) > static const struct dev_pm_ops tegra_aconnect_pm_ops = { > SET_RUNTIME_PM_OPS(tegra_aconnect_runtime_suspend, > tegra_aconnect_runtime_resume, NULL) > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > + pm_runtime_force_resume) > }; > > static const struct of_device_id tegra_aconnect_of_match[] = { Acked-by: Jon Hunter Cheers Jon -- nvpublic