Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp2885494imc; Wed, 13 Mar 2019 03:51:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8yjrq33Q/DV8W318NnUJ44uRLr/DWNxhY87NLMrV4rR4jdESXcDYk4fxl0vfqF8tZYjcK X-Received: by 2002:a62:ed06:: with SMTP id u6mr42484681pfh.132.1552474297409; Wed, 13 Mar 2019 03:51:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552474297; cv=none; d=google.com; s=arc-20160816; b=d0r5886pA9jNQH1BJO242XnLdC1WFV0IFi3IAuKk8572wPdNk5c0ILnTrjQ1NvVM7B MLZb3e1ChPQfn5AAY28PrjoHV0KKw2bvfIfC803wyxUdmHjRcQvVYpMpTmj2Gi8iTsVP I/tU01jhTjsD8IT0r5BErkKTrzYU5VZ2jWtMtw84QwYb1sIDmNfBEgz89hY/mOmWsah7 raIONJG2qu86uyY2Yo/G5zziqk+Qkoo+qsC5uTvL8Cf70XB0ftRPPzsTOhbCG4QGth9u 1jLqAiGSp55ZMItzY4EIekinnBJtta2AZr42mV8ooMlcH44qNvGllxmegCKt9JUiOWsw aZ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=YhzR6aubWEYgzikBR/ws80jTTDYj/MkeU9A7euzIPNw=; b=zjFgqw9anPnudwtinrG0fCXXdWD78MGoiWYcuS3hFFJdBK3D09pr+lcjDZYreJEqjE zPD3OfZvvYW0jFKeU0j5Wqkl9M+DotuNyOLrSRQqLQD8AelQ2setTHZedw8LjNZWtq2T lzqeHpOTPr4j/4pKTN5n8iedrzBzoZvfUfxu7VjLUAfc8gOMVYt0nxk9EkQZApyQ7+bW OHXp+rM8GVitkKL7z/bOX3AdnNmWPnn/tsptvB7ykzmFaEfSbkLUp9ymNxftS3FQTgi0 F/3HRQ7W7NfAdOtKpZ2jb+aRhQ18SkBsGL4Vojh6665QYHarG6YHlOvTC7U9jIfXiSQS 3S/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=N0xPSEvm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g186si10175326pfc.58.2019.03.13.03.51.21; Wed, 13 Mar 2019 03:51:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=N0xPSEvm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbfCMKtV (ORCPT + 99 others); Wed, 13 Mar 2019 06:49:21 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:44755 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfCMKtV (ORCPT ); Wed, 13 Mar 2019 06:49:21 -0400 Received: by mail-qt1-f196.google.com with SMTP id d2so1236900qti.11 for ; Wed, 13 Mar 2019 03:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YhzR6aubWEYgzikBR/ws80jTTDYj/MkeU9A7euzIPNw=; b=N0xPSEvm2SMEiqkEn5mdNzntu4XU15JPKSEEvdM8WOKL1gpkmakRljsyBOThrIPneb 7jrbcIZ6Pz/SrAKvRsR5b5ZBRhDlhEBG5RU6/gb3exWTM/wnG+thegzV0W00kRHmCQjI 2gOfDI6rqDI9q+MlF9e6078Cwd1xnt1PVO5Sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YhzR6aubWEYgzikBR/ws80jTTDYj/MkeU9A7euzIPNw=; b=OdQ4Znlp8wuV7FL8KA3h/m2/Iaz5ghIqRxVP2bef2chP5BMk8plKsJBEKCL7qPnUrs uCdq1g8N+pby8E4RBuF/HR2xk3SluqIpPzL3AQ6m8HZKT2Q0lKQU2R9bpNZOPsLkYigz b8cdV9BDtWFUsDO0qbfKy62aWm400FjLega9FKqsTakLyJ/baQQI/G93RQlQPIM2GO1q +5+/CKAiyybyel0JcZmAJXM4Fx3K5aIxjaejGWNFhueclwxYe08ZG4OsjM6HyhSZSFQU MYi8f/bYXtCMKygoe4LyZ6MeRjfMjO1XcIw7MrTqfhQ38lyfPnddnjmTsrye4X1c9afN llbw== X-Gm-Message-State: APjAAAWcsone3/+3cTlMHAPI3KEaACWqq7JO0v5kRcgIrKMYXy8xRdnN AFT21TxIulU1ulXGGJUk68ZFipHX1C05CoIqAtQRzA== X-Received: by 2002:ac8:2847:: with SMTP id 7mr33275907qtr.335.1552474159659; Wed, 13 Mar 2019 03:49:19 -0700 (PDT) MIME-Version: 1.0 References: <1552465563-6940-1-git-send-email-yongqiang.niu@mediatek.com> In-Reply-To: <1552465563-6940-1-git-send-email-yongqiang.niu@mediatek.com> From: Nicolas Boichat Date: Wed, 13 Mar 2019 18:49:08 +0800 Message-ID: Subject: Re: [RESEND PATCH v1, 00/18] add drm support for MT8183 To: Yongqiang Niu Cc: CK Hu , Philipp Zabel , Rob Herring , Matthias Brugger , Mark Rutland , devicetree@vger.kernel.org, David Airlie , lkml , dri-devel@lists.freedesktop.org, "moderated list:ARM/Mediatek SoC support" , linux-arm Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 13, 2019 at 4:53 PM Yongqiang Niu wrote: > > This series are based on 4.20-rc1 and provide 18 patches to > support mediatek SOC MT8183 v1 (https://patchwork.freedesktop.org/series/54451/#rev1) had a large number of comments, and I don't think you addressed any of them here? Can you please do so before resending? > Yongqiang Niu (18): > drm/mediatek: update dt-bindings for mt8183 > drm/mediatek: add mutex mod and sof into ddp private data > drm/mediatek: redefine mtk_ddp_sout_sel > drm/mediatek: move rdma sout from mtk_ddp_mout_en into > mtk_ddp_sout_sel > drm/mediatek: add ddp component CCORR > drm/mediatek: add mmsys private data for ddp path config > drm/mediatek: add commponent OVL0_2L > drm/mediatek: add component OVL1_2L > drm/mediatek: add component DITHER > drm/mediatek: add gmc_bits for ovl private data > drm/medaitek: add layer_nr for ovl private data > drm/mediatek: add function to connect module with it's previous one > drm/mediatek: add ddp write register common api > drm/mediatek: add connect function for ovl > drm/mediatek: add RDMA1 fifo size into RDMA private data > drm/mediatek: add function mtk_ddp_comp_get_type > drm/mediatek: add ovl0/ovl0_2l usecase > drm/mediatek: add support for mediatek SOC MT8183 > > .../bindings/display/mediatek/mediatek,disp.txt | 11 +- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 64 ++- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 23 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 42 +- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 458 ++++++++++++++++----- > drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 11 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 100 +++++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 24 ++ > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 55 +++ > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 4 + > 10 files changed, 688 insertions(+), 104 deletions(-) > > -- > 1.8.1.1.dirty > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel