Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3013115imc;
        Wed, 13 Mar 2019 06:53:34 -0700 (PDT)
X-Google-Smtp-Source: APXvYqzRHR12gzi/xmVqqT/9MajIbdEDdvCleSiKYt4sEkKvvFc72PyAvJu1WYNupEpoRV/pg8U7
X-Received: by 2002:a17:902:b188:: with SMTP id s8mr26593042plr.327.1552485214810;
        Wed, 13 Mar 2019 06:53:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1552485214; cv=none;
        d=google.com; s=arc-20160816;
        b=j+mssvO9LhnKJaEoV/RmVjuUTqA5HMBCySlgNnsmvA74qom3ubBH7LJ2iigs6+1WQv
         D6j56hPs8Rs/TE/W9T6oR4X1N/06HwejFrT0bINe62N/coN/MtQcN7MlOeoZc1sCG+cN
         JlsTfse6wqzm89M7/7uGHOM9FxyIJXJPyInIyVisU0z0Ool0g71yq5T2f4TRlJMciSrd
         LDW084a7YIEE0cpFAANugDDyYZpUy3ufFc7LAP55aEcaKZTICe4Fz+K6ytd/OjVdDgYu
         k4YurpnC2d+Pg9mV8evJAADLsV+YVFrtjlDKYLHk7fq8AdhmjtBq1ESiFsMw/vWnpTS6
         bW6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=3SwpHPghf1PqiRkFu6VgQya4xF3Yy7DP0MzigPG3dio=;
        b=IuqYgobaf1CRfz7z7vKMzycOS0RB19oZnmLxppJUPijVxUxu7Lvzlrg1xoEKCDGV4A
         4X6BwgUbkAv9bdcalsTnU28fKOS1WwGTix0V8jYALOTLzgzEyicC5XVnwSo5Uu9ERLG8
         8iaGQA+guu8tAYugkauVVtj/DG7TVx7/UH1+DZVXA3XNzHk7t/xd6hNalWqIBodzNxFi
         EtbrsIYYoVuuyC7asDcDeZqt093GFIifos6o4Cq+sOFPCrva6DdN0ntgHwMp0NeJtYoy
         Mc7k+CbqyAmQA1exPh1r5W2nyR6xf0mMAKfIGse62PeiPlC12lwjSVZM/UrIjshEUGsM
         Xj3Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="ad/otPZ1";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id h2si9844071pgp.60.2019.03.13.06.53.18;
        Wed, 13 Mar 2019 06:53:34 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="ad/otPZ1";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727106AbfCMNwV (ORCPT <rfc822;michael.k.kehoe@gmail.com>
        + 99 others); Wed, 13 Mar 2019 09:52:21 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:16562 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726971AbfCMNuh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Mar 2019 09:50:37 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5c890aab0001>; Wed, 13 Mar 2019 06:50:35 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 13 Mar 2019 06:50:36 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 13 Mar 2019 06:50:36 -0700
Received: from [10.25.74.242] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 13 Mar
 2019 13:50:28 +0000
Subject: Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support
To:     Marc Zyngier <marc.zyngier@arm.com>, <tglx@linutronix.de>,
        <jason@lakedaemon.net>, <catalin.marinas@arm.com>,
        <heiko@sntech.de>, <horms+renesas@verge.net.au>,
        <maxime.ripard@bootlin.com>, <andy.gross@linaro.org>,
        <olof@lixom.net>, <bjorn.andersson@linaro.org>,
        <jagan@amarulasolutions.com>, <enric.balletbo@collabora.com>,
        <stefan.wahren@i2se.com>, <ezequiel@collabora.com>,
        <marc.w.gonzalez@free.fr>, <christoffer.dall@arm.com>,
        <drjones@redhat.com>, <julien.thierry@arm.com>
CC:     <will.deacon@arm.com>, <treding@nvidia.com>,
        <jonathanh@nvidia.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>
References: <1552474956-25513-1-git-send-email-spujar@nvidia.com>
 <0cd78fb7-4bcb-b735-54ca-24a179b9ff72@arm.com>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <bc00b804-2248-4f8b-1537-3e3db151d74d@nvidia.com>
Date:   Wed, 13 Mar 2019 19:20:24 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.3
MIME-Version: 1.0
In-Reply-To: <0cd78fb7-4bcb-b735-54ca-24a179b9ff72@arm.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1552485035; bh=3SwpHPghf1PqiRkFu6VgQya4xF3Yy7DP0MzigPG3dio=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=ad/otPZ1oUlxT2cHsukFKIZALv39qKjqcA9njbns5fadavCS99yAgDjBckBtwy9dN
         TGzRjXd6V9izsLnxsnpAtLmqhRY/IrSTj2RP4oPlGQRN/7htED4JGoRUt+BJccJyd9
         0THPYzNGWqwJbxtM4jVXXr11sI/cLsIxKEA5pIZNXMB7HCeqADxm/JQxdxNFYGSYKq
         CqsUcPaHkYOYLVKEUGN1byAdKdhsIkoOMAYiNLl9Mt+dzAZIf1cLvW76h+H28qjvdZ
         zM6zyGj+P8U3QjbiqxmN6/3WjiU/1UCPsAaGqiarbEXDCdRIQdcSm+NW5Xksmq+RWH
         R2sSxPEKjwB2Q==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/13/2019 4:52 PM, Marc Zyngier wrote:
> First things first:
>
> - Where is the cover letter?
> - This series should be flagged as v2, as it not the same as the one you
> sent last week.
I had the dilemma whether to name this series as v2 or not, thought the 
commits
in the series are different and v2 may not be necessary.
Also felt commit messages are descriptive enough and all belong to 
irq-gic-pm,
hence did not send cover letter.
If you suggest so, I will send a cover letter next patch version(v2)
>
> On 13/03/2019 11:02, Sameer Pujar wrote:
>> This is a preparatory patch for using irq-gic-pm driver as module and thus
>> implement remove() call for the driver. Details of remove() are as below,
>>
>>   * pm_runtime_force_suspend() is added to balance runtime PM, otherwise
>>     following is seen: "agic-controller: Unbalanced pm_runtime_enable!"
>>   * Function gic_teardown() is exported from gic driver and called in remove
>>     to perform io unmap.
>>   * pm_clk_destroy() to free clock resources
>>   * irq is unmapped and freed with irq_dispose_mapping()
>>
> Let's be clear, I have no desire to export any GIC symbol at all. Why
> should we do this? This "driver" is the tiniest thing, and making it
> modular doesn't get us anything.
>
> So what's the rational for doing so?
Reason for this was, the driver gets used for AGIC block and audio is not
boot critical and hence module option was preferred.

Thanks,
Sameer.

>
> Thanks,
>
> 	M.