Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3024786imc; Wed, 13 Mar 2019 07:08:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqw+1X3orS48ItwLVNXxX2nUv49IU62Ia2cS3cHmtIFPfmuEll7aCtWE7VUz8I6ft+j86k+7 X-Received: by 2002:a17:902:8348:: with SMTP id z8mr47078971pln.151.1552486124248; Wed, 13 Mar 2019 07:08:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552486124; cv=none; d=google.com; s=arc-20160816; b=Bv/PYqdSW0u6ZiinZXISc0QyGHbKm3MybDVefEEsNZvVbowOC6Tb1oXCK80dr9UIDt CImt1sIncyT/8KnksNtz2Wc3AZ0iQ5+VSbyKO/Qf+oVsQGFlcgfJ4HanwqnhB04LTLSe D+3f22nciXJhL80FQ8KSO5IQn5aI5Af2llIFQlzUR8zSElkBvqDtqTnN/Je/jjGvJxmU 4fRTZEJwJjb9E3/i6EU+uoGh6wdDdC/N6Hj0hwAZRdLRgU2ondhVLeMyMymrb5kBPN0G bIgevTNISclaui33tXpgACoCWUn40ortQE/8KXRz6P0kR7ulKVWTolYPVmypoz9gsUXd 6muQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pu4HXcUgnCvLWkLKl5ktrqgvoaJtVt9pPuzT257F9NM=; b=JpBApeZIP+B8JZ7uC3syf/cBZJ3UjFiarqXxVxDjJaY2EtLcmEcowi+b8Yuy0fF3BE 22rCygiRp7jQsgo0MKsHgPZv6IU7blrxzFDNoCYEN7l73Qrf6hRdLcvYpNaK92q5Dllh KD0mlwSlalQgN96LWxcNJ6T+LuelaXPzs96IMINUtGLyvaYBkEryBjQ1UBhPTDgRtt7C P+npQxekpzy7Suj/sjKex82f5Et5YfT1VagyQ/44FQhXnsCGiL3nzcFKJHy6TFpCcVsq XTqOL3CYuyd5E66xvCKQR+UZylKaIvtXtJHe86BOMhoPdsiQlXNjkBuvicEeDNgVDeWV ROHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=qO25broX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f6si10221141pfn.108.2019.03.13.07.08.28; Wed, 13 Mar 2019 07:08:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=qO25broX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbfCMOGO (ORCPT + 99 others); Wed, 13 Mar 2019 10:06:14 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49202 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbfCMOGO (ORCPT ); Wed, 13 Mar 2019 10:06:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pu4HXcUgnCvLWkLKl5ktrqgvoaJtVt9pPuzT257F9NM=; b=qO25broXuoxF2ofckyAx5jeta kNeI37ke4AQinxN2ayVbdVrgaxJHMh5HzKcphUB/EhNiAIVeokn/dC5a6QUvc3+tf59/Bv40a3AKJ 597FZoFxJIsz5EumV8TVKVPdqP+r0uQvCZyouSKALggjyeuLdZCiwl1MJWg0FHml1TyuhPnRfxySv cUEEi1IjQOLmpD9vbAxrJI+zZjfOuqeuXHDgNs/VlhUxTizoM0Bz+7iftZ/uNXQTDiv5bw3NHXFol 8dg9UKPFD2lnfVF8H+yV9gsBmaHHFYkO3cfQiWFG8TWyBbxZbrysb/egAJmsl17pc+Rg04nFUL+qU 50h8k05mw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h44WC-0003DC-Qn; Wed, 13 Mar 2019 14:06:05 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9660A2028B0E8; Wed, 13 Mar 2019 15:06:03 +0100 (CET) Date: Wed, 13 Mar 2019 15:06:03 +0100 From: Peter Zijlstra To: Patrick Bellasi Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-api@vger.kernel.org, Ingo Molnar , Tejun Heo , "Rafael J . Wysocki" , Vincent Guittot , Viresh Kumar , Paul Turner , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan Subject: Re: [PATCH v7 01/15] sched/core: uclamp: Add CPU's clamp buckets refcounting Message-ID: <20190313140603.GD5922@hirez.programming.kicks-ass.net> References: <20190208100554.32196-1-patrick.bellasi@arm.com> <20190208100554.32196-2-patrick.bellasi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190208100554.32196-2-patrick.bellasi@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 08, 2019 at 10:05:40AM +0000, Patrick Bellasi wrote: > +static void __init init_uclamp(void) > +{ > + unsigned int clamp_id; > + int cpu; > + > + for_each_possible_cpu(cpu) > + memset(&cpu_rq(cpu)->uclamp, 0, sizeof(struct uclamp_rq)); > + Is that really needed? Doesn't rq come from .bss ?