Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3058507imc; Wed, 13 Mar 2019 07:55:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqy99l0vPc7pOgAzWB+eUCkxrv93fdYLaN9SYtT4dvIU7Xzohp+MXwTej9Mw/pZVUw3jvR0/ X-Received: by 2002:a17:902:8690:: with SMTP id g16mr45635663plo.284.1552488934155; Wed, 13 Mar 2019 07:55:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552488934; cv=none; d=google.com; s=arc-20160816; b=CjSvknc2XWQX52ZmX2iSg302XtiUGW4DoHPnENdRcs0LSSTLrjg7WBnVp8jmbPuYfT KgiONpLDy+RUDFqReAlg+tn3QmrSBGYnvdnc6hDJz6/JiRrzQgEwJMjDOSDvtv/oFycY 1PR0mJ09oMASE1vIsKui8kGUWf6bTkxOwsi4BwUpuztGR0fIpA1C5dkToTV85n97LX22 dy1igIZJz/sIN21xeaXOw5XguiY4mb2FWH4izmaS7psp7OFtPFmUO8+NnDf4xqSjuiPx C3Vq1qBi7+//PJmaIjEKFSdFSDmnv5yIlJta2m1IgNFNMTqDkIjUuyK+QOkVfbxWlsAU djMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature; bh=FGHlU6RQ5cUiMTkTZ+dDQRlmdCpLDztigm2epTXfLmo=; b=ZVCdx03xwjONjpcKSbQNzAm329ufjMMXd1ubNJd2jhPqnv08eu2+GrpzpAee6Rx2Gk 86FH7zvT3qRg2tRnlacm1cLyKSsBXaDc1Bcs6JvYpCj3wyqwgFnPThbWXXpBZ7g5oDEJ M75cvq7sruuttiGtWciUJJdxE/++UZg5e+2Qj17LuWoYi/nIfc42LGEcp59/yuxI2ddT SVvXRqH+8K8/XzCl6Cnm9mjtet7EtO3Z3k9PfnmtjbJQFK3FYvtGTFMbwMhTP5vVN+RR WGfgtcRWEpdiRde/2eMQmiR0eDWENhcyKnWkNEPW7VDvDq+PevLZ5y+51LyZTlMmvQ8j GHXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HS+qQib9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2si8259086pgr.270.2019.03.13.07.55.17; Wed, 13 Mar 2019 07:55:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HS+qQib9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726272AbfCMOyX (ORCPT + 99 others); Wed, 13 Mar 2019 10:54:23 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:37206 "EHLO mail-wr1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbfCMOyX (ORCPT ); Wed, 13 Mar 2019 10:54:23 -0400 Received: by mail-wr1-f47.google.com with SMTP id y15so2355091wro.4; Wed, 13 Mar 2019 07:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=FGHlU6RQ5cUiMTkTZ+dDQRlmdCpLDztigm2epTXfLmo=; b=HS+qQib99j9EN+RbUbyq/1g6D54HvfHDe58WS16AUlkPTkjO+x0DK9+qkCHyrMX5oj bFDgKLuLHhflgT7TrAMZbVYoHGneERvkLtLARTMwtFh4I2X7tgDWnRURgip7/qhppCbx L6xtJSWOTyLOajaBzMmwBoQeIP63pn0pcAIhBNbIxg43aLzhWI5f6fkqw+bgh2dTtfEE tck+XA0vm3Yn8ndAvFiEGD3pFE5V90JMLyI52a/dhIH7oVRVLK5xlknzHSzhmOMr+DXe 8lEVt++tCvTDg963fAel0o8aFEHYz2lX4sSp87Vf9oWFw3Mb/S8yg6P22+gPOoGdhPZv JRLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=FGHlU6RQ5cUiMTkTZ+dDQRlmdCpLDztigm2epTXfLmo=; b=uBj7XgtI9X/rDo6fU06ZljirN1iAckbm+JjN4D9sSpONFcwzKJWWPuld3Z8oAmi06m O9UbMVwUKVlRVsIDzc1+cp12H91rAYaIl0AOlnV0eh8YuflYqDzDKnsVunAb/oYOE6r1 bALm7ipFOzZZy+hbAO60pTbPZ9POtP5ZYoIFxwLwPuGx22pf3vEtsUZEixG14WCfATWA 7gZyjG7/mfh3qnyBdyHSnEq8l23FDzLIepPYBqOHJCEXskEt28z5qC6DpzpobpwJTsdA lAawxVkXD4gLhpHeUJS+DuJRLPNXjdiNNn/uIWjbwOfY4qVViNTP/0qwbXvCXkImpC04 XMIg== X-Gm-Message-State: APjAAAVsqHfpqjYuEtcf+pCvWBRHyxsHp4tqoo+n3GMGB9wDZ/GBIS0g JdfNK/gHC5fgWkJtkdcku9c= X-Received: by 2002:a5d:6b4c:: with SMTP id x12mr6272759wrw.14.1552488861412; Wed, 13 Mar 2019 07:54:21 -0700 (PDT) Received: from K55DR ([86.57.255.94]) by smtp.gmail.com with ESMTPSA id a14sm14990377wrx.96.2019.03.13.07.54.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 13 Mar 2019 07:54:20 -0700 (PDT) Date: Wed, 13 Mar 2019 17:54:18 +0300 From: Alexander Pateenok To: Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Indirect call in vesafb driver Message-ID: <20190313145418.bwta37cogo7a4qtt@K55DR> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, There're several indirect calls in inline assembly in vesafb driver (drivers/video/fbdev/vesafb.c), and these calls cannot be automatically changed to retpolines. It's in vesafb_pan_display(): 73 __asm__ __volatile__( 74 "call *(%%edi)" and in vesa_setpalette(): 113 __asm__ __volatile__( 114 "call *(%%esi)" Is there need to use CALL_NOSPEC ? Thanks, Alex