Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263662AbUCUPHG (ORCPT ); Sun, 21 Mar 2004 10:07:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263663AbUCUPHG (ORCPT ); Sun, 21 Mar 2004 10:07:06 -0500 Received: from mx1.redhat.com ([66.187.233.31]:19587 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S263662AbUCUPHD (ORCPT ); Sun, 21 Mar 2004 10:07:03 -0500 Date: Sun, 21 Mar 2004 10:08:04 -0500 (EST) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Clay Haapala cc: Jouni Malinen , "David S. Miller" , Subject: Re: Crypto API and keyed non-HMAC digest algorithms / Michael MIC In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1142 Lines: 32 On Thu, 18 Mar 2004, Clay Haapala wrote: > I've redone the crypto crc32c implementation to make use of Jouni's > setkey() digest api. So now crypto crc32c checksums are just another > type of digest, rather than a new CRYPTO_ALG type. > > This implementation is still a wrapper for the actual computation > routine in lib/libcrc32c, per previous requests. The patch below > includes the code under lib and crypto. It requires Jouni's previous > patches to be applied, and was tested on 2.6.4 kernel source. > > Let me know how it looks, especially if I should add further tests in > tcrypt. This looks fine, could you split it into two patches, one with the libcrc32c code and then one with the crypto algorithm? Also, in the configuration help, "This implementation uses lib/crc32c" should be ""This implementation uses lib/libcrc32c". - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/