Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3132725imc; Wed, 13 Mar 2019 09:35:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqyaBCj0e9nJetfUaEJTY1nj8CunGAo3bNwjo8OQFN4Y2mQmcdSTzZIaAn/dDsWTjAUytJbP X-Received: by 2002:a17:902:bd87:: with SMTP id q7mr45600632pls.227.1552494920274; Wed, 13 Mar 2019 09:35:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552494920; cv=none; d=google.com; s=arc-20160816; b=SO/pkimM5KSySlcNptDf4bMnCxJ4KF0qcv+CVGPy2vBNipzhnJagFWZYidHBmxBxMC DQiKquKPPjwk4hS+T8jbJsA+tWKQ+KXBYqvqPwFNNuNZUIKhdLLdJpyEe7/NYXRO7vHN CmR9AxJbQelz/otOwdgTfDAjTCie5YCE0n+PFs1XRp6MKjEKpCRna8HuTY/ve7ROVDF9 zC/Kp3ede/k0kld9IGeiYfZtIdIeI+Bmsh+xWmmpqDOXigegeex3zSG6MhoUyC2aLjpW By1KZIoj5FFvVyb7m5CxYJr2iMQ8zpw6RRaqjIL1OfHd8SGEl6HZ/MP09fC1u7x0wt2u lUkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=zjyj99JG3Ny/PihcAGrp5c2cYQReI0DjyeaAR3NO0DI=; b=pLVxUDgj1qlImPZZ69x8FTTVIytRXClmitvNklwAC0e1P1/oH2vIp1cnQZkZoxbDbm +e3pMnb/72EnLFVkbKw9B2U5vK+uy3IfNHXyiOnTkf2eupA1d1E4LVfXhm9jR0il2AM5 yLx6R0Ezc9IiTzbjjB+bSjh/hovwiFCM+OIvL8jk6tXe9bH+CWG7jqAWqDZK/XvFmF/6 i9ZrWR+g5rvRz/vwwp9c8lLMtm5IQh+2W8ffApeJQLymW3bNX4OLyCPYyUo69ZVBx5df geX2nWeEZBam1Tn0m5OiO0HdgzbD1bBKRdLijCw3T90RSoFCp2qM8Tr4L/5qskqjZUBp /Apg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qIQ3MYop; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9si10182358pgc.576.2019.03.13.09.35.02; Wed, 13 Mar 2019 09:35:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qIQ3MYop; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726444AbfCMQeX (ORCPT + 99 others); Wed, 13 Mar 2019 12:34:23 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:37549 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbfCMQeX (ORCPT ); Wed, 13 Mar 2019 12:34:23 -0400 Received: by mail-ot1-f65.google.com with SMTP id b3so2329222otp.4 for ; Wed, 13 Mar 2019 09:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zjyj99JG3Ny/PihcAGrp5c2cYQReI0DjyeaAR3NO0DI=; b=qIQ3MYopWQDSXG8cafFg9A36LEWRiou5XIKuitht9aulUiAQpWEOLU0P8S55T/r7U0 0RAhAunaxmhcEb7hx3nxRWSdcM7wLhAfbUThPtiewawcn3uLsPrI46SNi9S0u90sTtjf yTBoQbyNd90x+aDH43heA8Syp1SWG9KCWGcn0E2iBvZmWEFsQm5q0fZ5Ib5EV2eQG4GH YMPMKpECMuZUsWkCj5cSFS8zN47M/U4qP42UCjJhjKZGoDIMjRtZr+pqX5s230aebca7 BwWDgrH8D2ti0saJB2Bxlqt9RRHxivts2b1GB6RtmFNYLPmUO8IeieTrteulZku6ciN4 voCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zjyj99JG3Ny/PihcAGrp5c2cYQReI0DjyeaAR3NO0DI=; b=QL96uNKe002A7n1h+MzJ4p5oFqDRn/3yFZY2VcVkSjb+Jv2k0lBwZAESgCohXq9tLy 4vDZolgh6t6F+c9ftkDBJItCygt3frMGxnBOO27bQGWGa3hQRfWK7H+J49/gpA3I6hQ8 dknfQKdNBhJ/91EW1+GtU1vDN2/tJZez+M7neWljUIf5MFtLGmr7s2ml1XsNX2BdgWmi 0azu0oFxOfL2zY+zZ1HITu1BpEq5FRMwM4DCPN9daDj5vgAcSTBGCCBsjKB4KZ0uzyiZ u0SbrNjb8Bd1RCxEmPBWi0yTASsiS0PD+OpOlqfIff0eLqRGd6aZWavls/L+0jc3ZA4F IgEA== X-Gm-Message-State: APjAAAWoE58WkJgoWQYlwBzIG9Q5PzJyKEe++oyrQqm1jqW75BlxvYgP oPlJ+8bZ/5Inq10Rufr2pe0wJEHYaba0Z/x8VCQ= X-Received: by 2002:a9d:403:: with SMTP id 3mr27519048otc.110.1552494862495; Wed, 13 Mar 2019 09:34:22 -0700 (PDT) MIME-Version: 1.0 References: <20190313122403.248873-1-armax@google.com> In-Reply-To: From: Chuanhong Guo Date: Thu, 14 Mar 2019 00:34:11 +0800 Message-ID: Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c To: Matthias Brugger Cc: Armando Miraglia , NeilBrown , Armando Miraglia , Greg Kroah-Hartman , Stefan Roese , sankalpnegi2310@gmail.com, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Wed, Mar 13, 2019 at 8:28 PM Matthias Brugger wrote: > > > > On 13/03/2019 13:24, Armando Miraglia wrote: > [...] > Apart from fixing styling issues it would be usefull to see if we can add > support for mt7621 to drivers/spi/spi-mt65xx.c It's impossible. They are completely different IPs. > > Not sure if that is something you want to work on :) > > Regards, > Matthias