Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <ab0f6cff1dd07ec42f13894d0833fbd506bdc10a.camel@redhat.com>
Subject: Re: [PATCH 02/14] c6x: entry: Remove unneeded need_resched() loop
From:   Mark Salter <msalter@redhat.com>
To:     Valentin Schneider <valentin.schneider@arm.com>,
        linux-kernel@vger.kernel.org
Cc:     Aurelien Jacquiot <jacquiot.aurelien@gmail.com>,
        linux-c6x-dev@linux-c6x.org
Date:   Wed, 13 Mar 2019 13:21:58 -0400
In-Reply-To: <20190311224752.8337-3-valentin.schneider@arm.com>
References: <20190311224752.8337-1-valentin.schneider@arm.com>
         <20190311224752.8337-3-valentin.schneider@arm.com>
Organization: Red Hat, Inc
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-03-11 at 22:47 +0000, Valentin Schneider wrote:
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
> 
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Mark Salter <msalter@redhat.com>
> Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
> Cc: linux-c6x-dev@linux-c6x.org
> ---
>  arch/c6x/kernel/entry.S | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S
> index 2721c90b0121..17926e942edb 100644
> --- a/arch/c6x/kernel/entry.S
> +++ b/arch/c6x/kernel/entry.S
> @@ -567,7 +567,6 @@ resume_kernel:
>  	NOP	4
>   [A1]	BNOP	.S2	restore_all,5
>  
> -preempt_schedule:
>  	GET_THREAD_INFO A2
>  	LDW	.D1T1	*+A2(THREAD_INFO_FLAGS),A1
>  #ifdef CONFIG_C6X_BIG_KERNEL
> @@ -584,7 +583,7 @@ preempt_schedule:
>  #else
>  	B	.S2	preempt_schedule_irq
>  #endif
> -	ADDKPC	.S2	preempt_schedule,B3,4
> +	ADDKPC	.S2	restore_all,B3,4
>  #endif /* CONFIG_PREEMPT */
>  
>  ENTRY(enable_exception)

Acked-by: Mark Salter <msalter@redhat.com>