Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3225989imc; Wed, 13 Mar 2019 12:06:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqwoZL67FVmVsxH8L8rdHiHIeB2OWORkk8fWlhdpLG9FnrB7VjG0EUPcE4HUxlNw2KKrsjmX X-Received: by 2002:aa7:8a11:: with SMTP id m17mr3716468pfa.205.1552503974323; Wed, 13 Mar 2019 12:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552503974; cv=none; d=google.com; s=arc-20160816; b=0/YHIjCxNlgmioPlfLx59vu6s1YCLtcZPRoO/zYFYqF9+xE9/mOUD8qLyFQmFYxT5F 8MjVrOW6ZTXCHEUCIHm6DDFHVeUDgw9pkxBVhfWeftiMxLMLJoOBxgwGRyGEltj9e+O/ lkbUsAMj6EAJG0tAx9LoZ8QJamcfYVO/Zu9qaGh/NjD7ndd9fGt/r52G2YfCbO6bV1+G uEbp8smV5m5q2msGVWcUeCpe1Fpy+WPYnh6egbjKFzqxJbkJu6aa0NrqLeRanNbNXMLw qz/XI8YX2QZoUF1g0Xvx7y2NmmZfETq5s+RXPhB6TXKKhkh9rUCYauvwH+jcARJksnzE DD0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :references:message-id:in-reply-to:subject:cc:to:from:date :dkim-signature; bh=xipMzI5wN46dvzpIIeLGM7h+ZMHrHGWnWINaUjeKyFE=; b=B8+RRDF8coD1gM+ip9lm4WWLJdmsnR5hfF4s0RMaw4nQtX5O/ufuwbadFoHwUpL02v KKlhGIuEf7FVtrfC3w/yOXTy8H4sRAHzAyc5Lp5IlauxWJpj/qrvUmgmMQV2TyLpRFsY E7sEC+oBZtuRyCW5dcEVrNduxhd1Acm5OeM1t0Gcfq2pw1sTS51qfAGhdSQG/cRVEGBw rGQeaBAudUW6VjgAe/F00OyEYAS46W6nPlijIAgFzTCld+5Kgw8fW9q9XAFxiuX/wDbg MLFvlB5Qvj/qlRQAxsy5sc2bJuAaqZtw9J/4zixVgt3GKGUF/LUfMEENIVDTpr1nwKzC kbWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazonses.com header.s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw header.b=OnFv8cOO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si11556903pls.211.2019.03.13.12.05.58; Wed, 13 Mar 2019 12:06:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazonses.com header.s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw header.b=OnFv8cOO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726656AbfCMTFD (ORCPT + 99 others); Wed, 13 Mar 2019 15:05:03 -0400 Received: from a9-54.smtp-out.amazonses.com ([54.240.9.54]:46200 "EHLO a9-54.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbfCMTFD (ORCPT ); Wed, 13 Mar 2019 15:05:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1552503902; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:MIME-Version:Content-Type:Feedback-ID; bh=CDYmVMH7PAkHSQKUXC14Z3jOmSyhKpP/gELxNikp4NE=; b=OnFv8cOOAKVXVVH0bLgfTrhVe2UIZcprhHhFW2YY1sdh3KtqeMBoeQtcQ89QgZXi wuDP2mJSlDWEfGjhQnYOcArIhieEXw+1ymWBxk48McCj0ICnAfak74SADK3a1Jwgj9L lV6PQhPtLJxksHhczsozt4o3qKAqBsidqv3byjBA= Date: Wed, 13 Mar 2019 19:05:02 +0000 From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: "Tobin C. Harding" cc: Andrew Morton , Roman Gushchin , Pekka Enberg , David Rientjes , Joonsoo Kim , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] slob: Use slab_list instead of lru In-Reply-To: <20190313052030.13392-5-tobin@kernel.org> Message-ID: <0100016978719138-5260db28-77f5-4abb-8110-2732aa709c5e-000000@email.amazonses.com> References: <20190313052030.13392-1-tobin@kernel.org> <20190313052030.13392-5-tobin@kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SES-Outgoing: 2019.03.13-54.240.9.54 Feedback-ID: 1.us-east-1.fQZZZ0Xtj2+TD7V5apTT/NrT6QKuPgzCT/IC7XYgDKI=:AmazonSES Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Mar 2019, Tobin C. Harding wrote: > @@ -297,7 +297,7 @@ static void *slob_alloc(size_t size, gfp_t gfp, int align, int node) > continue; > > /* Attempt to alloc */ > - prev = sp->lru.prev; > + prev = sp->slab_list.prev; > b = slob_page_alloc(sp, size, align); > if (!b) > continue; Hmmm... Is there a way to use a macro or so to avoid referencing the field within the slab_list?