Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3271509imc; Wed, 13 Mar 2019 13:20:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbXdrVnxuEEaqyLW6c61VBcKZBDX1a4TSSSCz8kS+B6aekO5uBIzWJH3ksn0Hm0P+mts+S X-Received: by 2002:a63:cc43:: with SMTP id q3mr42233757pgi.387.1552508415610; Wed, 13 Mar 2019 13:20:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552508415; cv=none; d=google.com; s=arc-20160816; b=0d5JqiFNsKNEoCsSNLbNxqCpFSIKDvpghz4/FSVMuQxozD9wbyA5G2+Lo4US4zxnWJ YVNvOS5DkQZzpREyAOerZvd0GG/Cd02fZN4uoow4IZg1MkuXL5kqYvinnaf7fkojTvPV LLU18/HWa3r+11aPKiZOPS96QxgYih4OLS1WouMEMq4Eu23dPqTO7G7XUpSO1SFKbukc 6NPzi+Ozv/cUBszOwm6FpEi/0Z8FMfEZw97viP1x0EFbB1gSDJU9xk0/38IAnJHLCy2F RgCqOvjsMjEdHvmMg4tZe0gIjCcSfMdAoFvCyRBf91IksTierp3Qtj+qOMbCU58NlAG2 prtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+pFdgk6cbWEGojWdjJukIB3td/DgSUtUvsYCQXOeuRM=; b=jHM0GHJA7g0rNLk4D6leRiVdD4YGvllXgWgJYQwgpQr2NITu0rnuzkHlkKQ2RzrTNU R/Mjc5DjGYnnYO7GsHsaodSuSjylwTHcX36p9/pAlh2UowwYDoA8DXCZAE9f/SIqDnj7 3jywEzN2m+bFWTFyUYUKaT8juoWsBqIbE8VMBVfSIO4yrlyilITy7LWDsdPptofrdB+f jebmzKbgCNr9bCclc7K9l7+p2zi9ODQ1zYgcsH53fAI2CZzHmgWVzrOZpTc3JoYAegRR Gqte2edZa8KQFQBmagmHDjn5CogeQoBaGoktj5Ek9chiejj3XvLJqDhgasVya1uT7mP2 rWSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=sRiNA6dd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si10872483pfm.119.2019.03.13.13.19.59; Wed, 13 Mar 2019 13:20:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=sRiNA6dd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727255AbfCMUSc (ORCPT + 99 others); Wed, 13 Mar 2019 16:18:32 -0400 Received: from merlin.infradead.org ([205.233.59.134]:54466 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727087AbfCMUSc (ORCPT ); Wed, 13 Mar 2019 16:18:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+pFdgk6cbWEGojWdjJukIB3td/DgSUtUvsYCQXOeuRM=; b=sRiNA6ddWTnpXZHKSTOeg4m+B vu/tyNQS3DRHHa4kDJwgLDTQ+4dGTv459Wf1EhSFHyb/0oD7MbC14sdKAUU+7ntJaOaDUV7JDZ2Jq 0pDiUVM94DWbPjuYueWpA/4zsIL9bFPs59+MrFL5pVyZ5EJvuzKhC4mxB9UvC0gR4Hmo0BQ9qRI+e CeXbzjRj6pQZu1Z2r953wPVcopyRbxFbQp9OrulOR+bbgZERFOGn9ajjb9lup3/Wz8hO1o5MtLHjS Gbp3EQdaYnsppiIBCReZ2x23nVeOgotA5/kvf9Sqax5oeWYH8qX3iTsaYMMs4l020WP9H3aorWwWb Y9aMuSDjA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4AKU-0008SI-Tg; Wed, 13 Mar 2019 20:18:24 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 313AB9826C0; Wed, 13 Mar 2019 21:18:21 +0100 (CET) Date: Wed, 13 Mar 2019 21:18:21 +0100 From: Peter Zijlstra To: Patrick Bellasi Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-api@vger.kernel.org, Ingo Molnar , Tejun Heo , "Rafael J . Wysocki" , Vincent Guittot , Viresh Kumar , Paul Turner , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan Subject: Re: [PATCH v7 03/15] sched/core: uclamp: Add system default clamps Message-ID: <20190313201821.GW2482@worktop.programming.kicks-ass.net> References: <20190208100554.32196-1-patrick.bellasi@arm.com> <20190208100554.32196-4-patrick.bellasi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190208100554.32196-4-patrick.bellasi@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 08, 2019 at 10:05:42AM +0000, Patrick Bellasi wrote: > +static void uclamp_fork(struct task_struct *p) > +{ > + unsigned int clamp_id; > + > + if (unlikely(!p->sched_class->uclamp_enabled)) > + return; > + > + for (clamp_id = 0; clamp_id < UCLAMP_CNT; ++clamp_id) > + p->uclamp[clamp_id].active = false; > +} Because in that case .active == false, and copy_process() will have done thr right thing?