Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190114201911.13725-1-malat@debian.org> <20190313202429.20797-1-malat@debian.org>
 <CAHmME9psZb0XoKHjGP23TYsSwMU2G-WN81RKg8AvyY-rZLvy4g@mail.gmail.com>
In-Reply-To: <CAHmME9psZb0XoKHjGP23TYsSwMU2G-WN81RKg8AvyY-rZLvy4g@mail.gmail.com>
From:   Mathieu Malaterre <malat@debian.org>
Date:   Wed, 13 Mar 2019 21:52:41 +0100
Message-ID: <CA+7wUsxbieZVP3Bh8pXdemf2Q3qY3vAjE2y-Dg6yGF3oWHSPuQ@mail.gmail.com>
Subject: Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 13, 2019 at 9:34 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Conceptually this seems pretty reasonable. Though, style-wise, perhaps
> you might want to put those breaks on the next line too, i.e. s/;
> break;/;\n\t\tbreak;/?

Good point. This needs some more love since checkpatch complains now with:

ERROR: trailing statements should be on next line
#42: FILE: lib/siphash.c:77:
+ case 4: b |= le32_to_cpup(data);

Let me merge all that and send a v2.

Thanks