Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To:     Arnd Bergmann <arnd@arndb.de>, Jiri Kosina <jikos@kernel.org>,
        Jens Axboe <axboe@kernel.dk>
CC:     Omar Sandoval <osandov@fb.com>, Hannes Reinecke <hare@suse.de>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] floppy: fix harmless clang build warning
Thread-Topic: [PATCH] floppy: fix harmless clang build warning
Thread-Index: AQHU2eM4YAW9rIQZhEK1X8gWSQpJeKYKG6bw
Date:   Wed, 13 Mar 2019 22:01:43 +0000
Message-ID: <AT5PR8401MB116964D0C90783A164834C2CAB4A0@AT5PR8401MB1169.NAMPRD84.PROD.OUTLOOK.COM>
References: <20190313211433.4178148-1-arnd@arndb.de>
In-Reply-To: <20190313211433.4178148-1-arnd@arndb.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: hpe.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a8e2d4a-496d-45d9-1a88-08d6a7ff7ac9
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2019 22:01:43.6111
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB0578
X-OriginatorOrg: hpe.com
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-13_13:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1903130149
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Arnd
> Bergmann
> Sent: Wednesday, March 13, 2019 4:11 PM
> To: Jiri Kosina <jikos@kernel.org>; Jens Axboe <axboe@kernel.dk>
> Cc: Arnd Bergmann <arnd@arndb.de>; Omar Sandoval <osandov@fb.com>; Hannes Reinecke <hare@suse.de>;
> linux-block@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] floppy: fix harmless clang build warning
> 
> clang warns about unusual code in floppy.c that looks like it
> was intended to be a bit mask operation, checking for a specific
> bit in the UDP->cmos variable (FLOPPY1_TYPE expands to '4' on
> ARM):
> 
> drivers/block/floppy.c:3902:17: error: use of logical '&&' with constant operand [-Werror,-Wconstant-
> logical-operand]
>         if (!UDP->cmos && FLOPPY1_TYPE)
>                        ^  ~~~~~~~~~~~~
> drivers/block/floppy.c:3902:17: note: use '&' for a bitwise operation
>         if (!UDP->cmos && FLOPPY1_TYPE)
> 
> The check here is redundant anyway, if FLOPPY1_TYPE is zero, then
> assigning it to a zero UDP->cmos field does not change anything,
> so removing the extra check here has no effect other than shutting
> up the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/block/floppy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 95f608d1a098..56815446ed85 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -3899,7 +3899,7 @@ static void __init config_types(void)
>  	if (!UDP->cmos)
>  		UDP->cmos = FLOPPY0_TYPE;
>  	drive = 1;
> -	if (!UDP->cmos && FLOPPY1_TYPE)
> +	if (!UDP->cmos)
>  		UDP->cmos = FLOPPY1_TYPE;
> 
>  	/* FIXME: additional physical CMOS drive detection should go here */
> --
> 2.20.0

On x86 it expands to a hardware read, so this would change the control flow.

#define FLOPPY1_TYPE                                    \
({                                                      \
        unsigned long flags;                            \
        unsigned char val;                              \
        spin_lock_irqsave(&rtc_lock, flags);            \
        val = CMOS_READ(0x10) & 15;                     \
        spin_unlock_irqrestore(&rtc_lock, flags);       \
        val;                                            \
})