Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAH2r5muaceyqkrbXB7Bt-qv_vtVqZEmpafJa6B2+8kyRsK7ftQ@mail.gmail.com>
In-Reply-To: <CAH2r5muaceyqkrbXB7Bt-qv_vtVqZEmpafJa6B2+8kyRsK7ftQ@mail.gmail.com>
From:   ronnie sahlberg <ronniesahlberg@gmail.com>
Date:   Thu, 14 Mar 2019 08:14:21 +1000
Message-ID: <CAN05THR2MpsVC9LwDfFDPA4nD9VWjKeF25Nsi2vJ=gC6=mNqVQ@mail.gmail.com>
Subject: Re: [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity
To:     Steve French <smfrench@gmail.com>
Cc:     CIFS <linux-cifs@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

reviewed by me

On Thu, Mar 14, 2019 at 7:53 AM Steve French <smfrench@gmail.com> wrote:
>
> cifs: remove unused value pointed out by Coverity
>
> Detected by CoverityScan CID#1438719 ("Unused Value")
>
> buf is reset again before being used so these two lines of code
> are useless.
>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/cifs/connect.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index b95db2b593cb..a8e9738db691 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1191,10 +1191,6 @@ cifs_demultiplex_thread(void *p)
>              continue;
>          }
>
> -        if (server->large_buf)
> -            buf = server->bigbuf;
> -
> -
>          server->lstrp = jiffies;
>
>          for (i = 0; i < num_mids; i++) {
>
> --
> Thanks,
>
> Steve