Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] arch/powerpc: Rework local_paca to avoid LTO warnings
To:     Daniel Axtens <dja@axtens.net>,
        "Alastair D'Silva" <alastair@au1.ibm.com>
Cc:     Michal Hocko <mhocko@suse.com>,
        Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
        "Alastair D'Silva" <alastair@d-silva.org>,
        linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Paul Mackerras <paulus@samba.org>,
        "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
        linuxppc-dev@lists.ozlabs.org,
        Andrew Morton <akpm@linux-foundation.org>
References: <20190313034208.13134-1-alastair@au1.ibm.com>
 <87ef7atjnk.fsf@dja-thinkpad.axtens.net>
From:   Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Date:   Thu, 14 Mar 2019 11:09:42 +1100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <87ef7atjnk.fsf@dja-thinkpad.axtens.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-AU
Content-Transfer-Encoding: 7bit
Message-Id: <52392d47-4b69-2353-b831-6db4250bed78@au1.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 14/3/19 10:54 am, Daniel Axtens wrote:
>> +static inline struct paca_struct *get_paca_no_preempt_check(void)
>> +{
>> +	register struct paca_struct *paca asm("r13");
>> +	return paca;
>> +}
> 
> Isn't the convention to have the { on the same line as the function, or
> am I horrible mis-remembering things?

However, there is one special case, namely functions: they have the
opening brace at the beginning of the next line, thus:

         int function(int x)
         {
                 body of function
         }

Heretic people all over the world have claimed that this inconsistency
is ...  well ...  inconsistent, but all right-thinking people know that
(a) K&R are **right** and (b) K&R are right.  Besides, functions are
special anyway (you can't nest them in C).


-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited